Skip to content

WAF: Block config updates on cold miss #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciarams87 merged 2 commits into from
Apr 20, 2026

Update internal/controller/handler.go

9426abe
Select commit
Loading
Failed to load commit list.
Merged

WAF: Block config updates on cold miss #5135

Update internal/controller/handler.go
9426abe
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 20, 2026 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

❌ Patch coverage is 65.51724% with 30 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/nap-waf@76aee69). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/controller/handler.go 65.00% 11 Missing and 3 partials ⚠️
internal/controller/state/conditions/conditions.go 0.00% 6 Missing ⚠️
internal/controller/state/change_processor.go 20.00% 4 Missing ⚠️
internal/controller/manager.go 0.00% 3 Missing ⚠️
internal/controller/state/store.go 0.00% 2 Missing ⚠️
internal/framework/waf/manager.go 96.29% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##             feat/nap-waf    #5135   +/-   ##
===============================================
  Coverage                ?   85.85%           
===============================================
  Files                   ?      149           
  Lines                   ?    19437           
  Branches                ?       35           
===============================================
  Hits                    ?    16687           
  Misses                  ?     2416           
  Partials                ?      334

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov