-
Notifications
You must be signed in to change notification settings - Fork 68
add spell checker in CI/CD and Makefile #1582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
83523d4
Fixing typos that we spotted on the FAIRmat side given that we use cs…
atomprobe-tc 5579d7e
add spellchecker in CI/CD and Makefile
lukaspie 9446a8b
fix spelling in applications and base classes
lukaspie aa8275e
remove unused words
lukaspie 42f906e
use scientific_terms_US dictionary
lukaspie 07da317
update to newest npm
lukaspie 2e6fa17
remove words that exist in other dictionaries
lukaspie 77fae63
use global install in workflow
lukaspie 6b3cfef
clean up typos in contributed_definitions
lukaspie e356fac
clean up use of en-UK
lukaspie 716016d
some more typo fixes
lukaspie b4af87d
Implemented @PeterC-DLS comments
atomprobe-tc aec4092
Iterating to a compromise for Peter's comments
atomprobe-tc ea31729
One more occurrence
atomprobe-tc f22e097
Fixed spurious typing error, and made use of hashmark consistent
atomprobe-tc cfb6468
Fixed spurious typing error
atomprobe-tc f965ee6
Adding another suggestion for apm
atomprobe-tc fa46697
Working in further comments from PeterC-DLS
atomprobe-tc 1c6bf6d
Scripting from Peter and response from cspell via CI gives mismatch w…
atomprobe-tc e635ec7
Ran script on spellcheck CI raw log when using an empty custom-dictio…
atomprobe-tc 6ab6345
Indeed much better only a few German umlaut containing custom words t…
atomprobe-tc 1afe2d4
Have we catched them all now?
atomprobe-tc 7bd40f8
Merge branch 'main' into spellcheck
atomprobe-tc 0d3bc1c
Following the request from the 2025/09/16 telco to kick integration o…
atomprobe-tc 92da25b
Removal of make file target spellcheck as it will enforce a currently…
atomprobe-tc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Spell Check | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "applications/**/*" | ||
| - "base_classes/**/*" | ||
| - "contributed_definitions/**/*" | ||
|
|
||
| jobs: | ||
| spellcheck: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install dependencies and dictionary | ||
| run: | | ||
| npm install -g cspell jq @cspell/dict-scientific-terms-us | ||
|
|
||
| - name: Run cspell and format results | ||
| run: | | ||
| cspell --config cspell.json "applications/**/*" "base_classes/**/*" "contributed_definitions/**/*" | ||
|
|
||
| - name: Fail on errors | ||
| run: | | ||
| if [[ $? -ne 0 ]]; then | ||
| echo "There are spelling errors in your code. Please fix them and try again." | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.