-
Notifications
You must be signed in to change notification settings - Fork 68
Clarify the conventions for rotations in left and right handed coordinate system #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PeterC-DLS
merged 9 commits into
nexusformat:main
from
FAIRmat-NFDI:rotation-convention
May 16, 2025
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
29d23e9
explicitly define rotation conventions in NXtransformations
lukaspie 368ca63
Apply suggestions from code review
lukaspie 56ce51d
Apply suggestions from code review
lukaspie 4b46818
clean up docstring a bit
lukaspie 447d2f3
typo fixes
lukaspie 01c63ee
change viewing direction for rotation convention
lukaspie 4d389c7
review suggestions on wording
lukaspie 59aab24
Update base_classes/NXtransformations.nxdl.xml
lukaspie 5e25e8c
note on mcstas
lukaspie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.