feat(UI): Account wizard redesign#10030
Conversation
Signed-off-by: Rello <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Rello <[email protected]>
…ure/AccountWizard
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
I mean, obvious points of feedback are that the input field should be as big as the "Log in" button and the side/bottom padding for buttons should be equal, plus the buttons on the first screen should all take up as much width as possible, like on the second screen. The "Authorize this device in the browser window that opened." string can also be removed and the icons made the same as on the mockup. The colors of the primary buttons also don't meet contrast requirements, I don’t know where this color is from. Generally just getting it in-line with the mockup. |
|
Plus the "Add Nextcloud account" window title can be made invisible on Mac here. Each screen should give you enough context on its own. |
|
|
@kra-mo can you re-check the current screenshots? if ok we will do win/linux also |
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9995d5f252
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const auto defaultUrl = | ||
| Theme::instance()->multipleOverrideServers() ? QString{} : Theme::instance()->overrideServerUrl(); | ||
|
|
||
| _remoteFolder = Theme::instance()->defaultServerFolder(); | ||
| setServerUrl(defaultUrl); | ||
| const auto hasForcedConcreteServerUrl = | ||
| Theme::instance()->forceOverrideServerUrl() && !defaultUrl.isEmpty() && !Theme::instance()->multipleOverrideServers(); | ||
| setServerUrlEditable(!hasForcedConcreteServerUrl); |
There was a problem hiding this comment.
When overrideServerUrl() contains the JSON array used for forced multiple-server deployments, this initializes the QML wizard with an empty, editable URL instead of presenting the configured choices. The legacy setup page handled multipleOverrideServers() && forceOverrideServerUrl() by hiding the free-form field and populating a combo box from the JSON array, so this new path lets users type arbitrary servers and prevents them from selecting the branded servers.
Useful? React with 👍 / 👎.
| _qmlWizardWindow->show(); | ||
| _qmlWizardWindow->raise(); | ||
| _qmlWizardWindow->requestActivate(); | ||
| return true; |
There was a problem hiding this comment.
For single forced override URLs, ConfigFile::overrideServerUrl() still sets startLoginFlowAutomatically(), but the QML path now only shows the window and returns. The legacy OwncloudSetupPage::initializePage() immediately called validation for that scenario, so custom-link/branded launches that are supposed to open the browser login without user input now stop on a read-only server page until the user clicks Log in.
Useful? React with 👍 / 👎.
|
Artifact containing the AppImage: nextcloud-appimage-pr-10030.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
3 participants
closing #8822