Skip to content

CSV export fixes#6800

Merged
luka-nextcloud merged 4 commits intonextcloud:mainfrom
gidan80:main
Mar 31, 2025
Merged

CSV export fixes#6800
luka-nextcloud merged 4 commits intonextcloud:mainfrom
gidan80:main

Conversation

@gidan80
Copy link
Copy Markdown
Contributor

@gidan80 gidan80 commented Feb 28, 2025

Summary

Fixes CSV export: in particular escaping quotation marks and adds the "assigned user" column.

TODO

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@gidan80 Thanks for sending the PR. Code change looks okay. Regarding escaping quotation, the card title should be handled as well.

@gidan80
Copy link
Copy Markdown
Contributor Author

gidan80 commented Mar 21, 2025

I forgot about that. Should be fine now.

Signed-off-by: Ronni Dal Lago <[email protected]>
@gidan80
Copy link
Copy Markdown
Contributor Author

gidan80 commented Mar 21, 2025

I see thah the linter is throwing some errors. Do i need to force-push the corrections?

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@gidan80 Yes, please.

@gidan80 gidan80 force-pushed the main branch 2 times, most recently from 94da732 to 9867348 Compare March 21, 2025 18:01
Signed-off-by: Ronni Dal Lago <[email protected]>
@luka-nextcloud
Copy link
Copy Markdown
Contributor

@gidan80 The query count was increased. Pleas update the query count in tests/integration/base-query-count.txt to 81091.

Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment above.

@luka-nextcloud luka-nextcloud merged commit b0fbb38 into nextcloud:main Mar 31, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants