CSV export fixes#6800
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@gidan80 Thanks for sending the PR. Code change looks okay. Regarding escaping quotation, the card title should be handled as well. |
|
I forgot about that. Should be fine now. |
Signed-off-by: Ronni Dal Lago <[email protected]>
|
I see thah the linter is throwing some errors. Do i need to force-push the corrections? |
|
@gidan80 Yes, please. |
94da732 to
9867348
Compare
Signed-off-by: Ronni Dal Lago <[email protected]>
|
@gidan80 The query count was increased. Pleas update the query count in |
luka-nextcloud
left a comment
There was a problem hiding this comment.
Please check my comment above.
Signed-off-by: Ronni Dal Lago <[email protected]>
Summary
Fixes CSV export: in particular escaping quotation marks and adds the "assigned user" column.
TODO
Checklist