Perf: Optimize member list on the landing page for collective with large number of members#2518
Open
Koc wants to merge 1 commit into
Open
Perf: Optimize member list on the landing page for collective with large number of members#2518Koc wants to merge 1 commit into
Koc wants to merge 1 commit into
Conversation
…rge number of members Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is continuation of #2443. I had an attempt to implement lightweight API endpoint in circles module but stuck with it due to federated users. This is a really loong path which I'd prefer to avoid. Also keep in mind that we're reloading this members list every 1 minute due to background fetcher and endpoint latency goes up to 10s in our organization.
So, instead of that we're loading only 15 users for a landing page. And then re-loading all users once we toggle editor mode from readonly to edit. This improves performance of BE and do not degradates users autocomplete functionality in the editor.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)