Skip to content

fix(trashbin): expose source-calendar-uri and calendar-owner-principa…#1043

Open
hamza221 wants to merge 2 commits into
mainfrom
fix/trashbin/props
Open

fix(trashbin): expose source-calendar-uri and calendar-owner-principa…#1043
hamza221 wants to merge 2 commits into
mainfrom
fix/trashbin/props

Conversation

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 hamza221 commented May 23, 2026

Needed to match deleted objects to calendar in case of delegated or shared calendars

needs nextcloud/server#60648

…l-uri props

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/models/deletedCalendarObject.js 37.50% 10 Missing ⚠️
src/models/calendarTrashBin.js 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These properties need access methods, so that we don't use them like this:

const sourceUri = obj.dav._props['{http://nextcloud.com/ns}source-calendar-uri']

Copy link
Copy Markdown
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(works tho, approving for faster merge)

@hamza221 hamza221 force-pushed the fix/trashbin/props branch from 9aa07d5 to 27cf0b7 Compare May 27, 2026 12:02
Copy link
Copy Markdown
Contributor

@SebastianKrupinski SebastianKrupinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants