feat: add calendar delegation#1040
Open
GVodyanov wants to merge 2 commits into
Open
Conversation
1 task
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
SebastianKrupinski
force-pushed
the
feat/calendar-delegation
branch
from
447a2d9 to
c0822ce
Compare
This was referenced May 23, 2026
ChristophWurst
approved these changes
May 26, 2026
Comment on lines
+569
to
+578
| async getCalendarHomeUrlForPrincipal(principalUrl) { | ||
| const { body } = await this._request.propFind(principalUrl, [ | ||
| [NS.IETF_CALDAV, 'calendar-home-set'], | ||
| ]) | ||
| const homes = body[`{${NS.IETF_CALDAV}}calendar-home-set`] | ||
| if (!homes || !homes.length) { | ||
| return null | ||
| } | ||
| return this._request.absoluteUrl(homes[0]) | ||
| } |
Contributor
There was a problem hiding this comment.
We already do this in _extractCalendarHomes (at the bottom) all the homes are map to this.calendarHomes
Comment on lines
+498
to
+501
| getCalendarHomeForUrl(calendarHomeUrl) { | ||
| const url = this._request.pathname(calendarHomeUrl) | ||
| return new CalendarHome(this, this._request, url, {}) | ||
| } |
Contributor
There was a problem hiding this comment.
All the calendar homes are mapped to this.calendarHomes already, there should be no need to do this again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for nextcloud/calendar#8085
@SebastianKrupinski @tcitworld As per your requests, here is the service from the calendar PR