Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
============================================
+ Coverage 70.36% 70.64% +0.28%
- Complexity 10473 10619 +146
============================================
Files 873 881 +8
Lines 42329 42913 +584
Branches 6433 6486 +53
============================================
+ Hits 29784 30318 +534
- Misses 9642 9672 +30
- Partials 2903 2923 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #847
Overview
Adds support for JMX metrics from Solr v9.x up to (but not including) v10.
A replica of the Solr JMX v7.4.0 module except for the following...
Our instrumentation point for Solr v9 no longer accepts a SolrInfoBean instance in the
SolrMetricManager_Instrumentation.registerMetric()method. Instead, it takes a SolrMetricsContext instance, which no longer exposes a getName method, which was used to generate metric names.To handle this, a new class,
SolrComponentRegistrywas created. This class is used to mapgetTag()values (fromSolrMetricsContext) to correspondingSolrInfoBean.getName()values. This allows Solr 9.0 instrumentation to maintain metric name parity with Solr 8.x. TheSolrComponentRegistryinstance is populated via theSolrCoreMetricManager_Instrumentation.registerMetricProducer()instrumentation point.In some cases, metrics may be created before the bean name is known, so they use fallback names like "updateHandler". When the proper bean name (the fully qualified package/class name) is registered later, all matching metrics that are currently stored in the MetricUtil class get retroactively updated..
Added some additional tests for the new context class and bean name update logic.