feat(k8s): register system identities through cli command

Tiltfile

@@ -120,6 +120,7 @@ ac_flags = [
   '--set=agentControlDeployment.chartValues.config.cdRemoteUpdate=' + enable_cd_remote_update,
   '--version=>=0.0.0-beta',
   '--set=agentControlDeployment.chartValues.image.imagePullPolicy=Always',
+  '--set=agentControlDeployment.chartValues.toolkitImage.imagePullPolicy=Always',
   '--values=' + sa_chart_values_file,
 ]
 
@@ -193,7 +194,8 @@ helm_resource(
   flags=ac_flags,
   image_deps=['tilt.local/agent-control-dev', 'tilt.local/agent-control-cli-dev'],
   image_keys=[('agentControlDeployment.chartValues.image.registry', 'agentControlDeployment.chartValues.image.repository', 'agentControlDeployment.chartValues.image.tag'),
-              [('toolkitImage.registry', 'toolkitImage.repository', 'toolkitImage.tag')]],
+              [('agentControlDeployment.chartValues.toolkitImage.registry', 'agentControlDeployment.chartValues.toolkitImage.repository', 'agentControlDeployment.chartValues.toolkitImage.tag'),
+               ('toolkitImage.registry', 'toolkitImage.repository', 'toolkitImage.tag')]],
   resource_deps=ac_chart_deps
 )
 

agent-control/Cargo.toml

@@ -32,7 +32,7 @@ semver = { workspace = true, features = ["serde"] }
 chrono = { workspace = true }
 base64 = { version = "0.22.1" }
 # New Relic dependencies (external repos)
-nr-auth = { git = "https://github.com/newrelic/newrelic-auth-rs.git", tag = "0.2.0" }
+nr-auth = { git = "https://github.com/newrelic/newrelic-auth-rs.git", tag = "0.4.0" }
 opamp-client = { git = "https://github.com/newrelic/newrelic-opamp-rs.git", tag = "0.0.36" }
 # local dependencies
 fs = { path = "../fs" }

agent-control/src/agent_control/config.rs

@@ -391,6 +391,13 @@ pub fn deployment_type_meta() -> TypeMeta {
     }
 }
 
+pub fn secret_type_meta() -> TypeMeta {
+    TypeMeta {
+        api_version: "v1".to_string(),
+        kind: "Secret".to_string(),
+    }
+}
+
 pub fn default_group_version_kinds() -> Vec<TypeMeta> {
     // In flux health check we are currently supporting just a single helm_release_type_meta
     // Each time we support a new version we should decide if and how to support retrieving its health
@@ -400,10 +407,7 @@ pub fn default_group_version_kinds() -> Vec<TypeMeta> {
         instrumentation_v1beta3_type_meta(),
         // This allows Secrets created as dynamic objects to be cleaned up by the GC
         // This should not be needed anymore whenever the GC detection logic doesn't rely on this list.
-        TypeMeta {
-            api_version: "v1".to_string(),
-            kind: "Secret".to_string(),
-        },
+        secret_type_meta(),
         helmrepository_type_meta(),
         helmrelease_v2_type_meta(),
     ]

agent-control/src/bin/main_agent_control_k8s_cli.rs

@@ -1,8 +1,10 @@
-use clap::{Parser, Subcommand};
+use clap::error::ErrorKind;
+use clap::{CommandFactory, Parser, Subcommand};
 use newrelic_agent_control::cli::common::{error::CliError, logs};
 use newrelic_agent_control::cli::k8s::install::agent_control::InstallAgentControl;
 use newrelic_agent_control::cli::k8s::install::flux::InstallFlux;
 use newrelic_agent_control::cli::k8s::install::{InstallData, apply_resources};
+use newrelic_agent_control::cli::k8s::system_identity::{self, register_system_identity};
 use newrelic_agent_control::cli::k8s::uninstall::agent_control::{
     AgentControlUninstallData, uninstall_agent_control,
 };
@@ -41,6 +43,9 @@ enum Operations {
     /// Remove the resources created to handled the Continuous Deployment utility
     #[clap(name = "remove-cd-resources")]
     RemoveCDResources(FluxUninstallData),
+
+    /// Registers the System Identity to be used in Agent Control for authentication.
+    RegisterSystemIdentity(system_identity::Args),
 }
 
 fn main() -> ExitCode {
@@ -67,6 +72,14 @@ fn main() -> ExitCode {
         Operations::RemoveCDResources(cd_data) => {
             remove_flux_crs(&cli.namespace, &cd_data.release_name)
         }
+        Operations::RegisterSystemIdentity(args) => match args.validate() {
+            Ok(spec) => register_system_identity(&cli.namespace, spec),
+            Err(err) => {
+                let mut cmd = Cli::command();
+                cmd.error(ErrorKind::ArgumentConflict, err.to_string())
+                    .exit()
+            }
+        },
     };
 
     match result {

agent-control/src/bin/main_agent_control_onhost_cli.rs

@@ -37,7 +37,7 @@ fn main() -> ExitCode {
 
     let result = match cli.command {
         Commands::GenerateConfig(args) => match args.validate() {
-            Ok(inputs) => config_gen::generate(inputs),
+            Ok(params) => config_gen::generate(params),
             Err(err) => {
                 let mut cmd = Cli::command();
                 cmd.error(ErrorKind::ArgumentConflict, err.to_string())