[nr-k8s-otel-collector] Update ConfigMap formatting for kubectl edit#2194
Draft
bpschmitt wants to merge 1 commit intonewrelic:masterfrom
Draft
[nr-k8s-otel-collector] Update ConfigMap formatting for kubectl edit#2194bpschmitt wants to merge 1 commit intonewrelic:masterfrom
bpschmitt wants to merge 1 commit intonewrelic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ConfigMap Indentation Fix - Summary
Problem
Configmaps were displaying escaped newline characters (
\n) when viewed withkubectl edit, making them unreadable.Root Cause
nindentadds newlines + indentation and is designed for injecting YAML into YAML structures|),nindentwas escaping newlines instead of treating them as literal textChanges Made
1.
charts/nr-k8s-otel-collector/templates/_config_map.tpldefinestatements (they were output as extra whitespace)if/endstatements now at column 0)| indent Nfilter to alltoYamlcalls to handle indentation within the template:indent 6for receivers, processors, exporters, connectorsindent 8for pipelines2.
charts/nr-k8s-otel-collector/templates/deployment-configmap.yaml| nindent Nfilters from include calls inside the literal block3.
charts/nr-k8s-otel-collector/templates/daemonset-configmap.yaml| nindent Nfilters from include calls inside the literal blockResult
kubectl edit\ncharacters in the outputWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])Release Notes to Publish (nr-k8s-otel-collector)
If this PR contains changes in
nr-k8s-otel-collector, please complete the following section. All other charts should ignore this section.🚀 What's Changed