fix(link): use overwrite=true in upgrade/reinstall and surface conflicts#26
Merged
Conversation
Upgrade and reinstall now pass overwrite=true to link_package, ensuring cross-package symlink conflicts are resolved instead of silently skipped (which left packages partially linked with no visible error). A new LinkResult struct tracks overwritten files so users see a warning when conflicts occur. The parallel installer and explicit link command also surface overwrite counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stout upgrade(andstout reinstall) calledlink_packagewithoverwrite=false. When a cross-package symlink conflict existed, the conflicting files were silently skipped — only atracing::warn!log was emitted, invisible to the user. The package appeared upgraded but was partially linked, requiring a manualstout link --overwrite <pkg>to fix.Changes
LinkResultstruct added tolink.rswithlinkedandoverwrittenfile lists, replacing the bareVec<PathBuf>return typeoverwrite_or_skip!macro tracks files removed due to cross-package conflictsupgradeandreinstallnow passoverwrite: trueand print a warning with overwrite countlinkcommand and parallel installer also surface overwrite counts to the userAll 169 workspace tests pass.