Skip to content

Add Mikrotik RouterOS interface wireless templates - #2300

Open
k-ribot wants to merge 1 commit into
networktocode:masterfrom
unyc-io:add-mikrotik-routeros-interface-wireless-templates
Open

Add Mikrotik RouterOS interface wireless templates#2300
k-ribot wants to merge 1 commit into
networktocode:masterfrom
unyc-io:add-mikrotik-routeros-interface-wireless-templates

Conversation

@k-ribot

@k-ribot k-ribot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Add Mikrotik RouterOS interface wireless templates

@k-ribot k-ribot closed this Mar 23, 2026
@k-ribot
k-ribot deleted the add-mikrotik-routeros-interface-wireless-templates branch March 23, 2026 09:40
@k-ribot
k-ribot restored the add-mikrotik-routeros-interface-wireless-templates branch March 23, 2026 09:40
@k-ribot k-ribot reopened this Mar 23, 2026
@k-ribot
k-ribot force-pushed the add-mikrotik-routeros-interface-wireless-templates branch 5 times, most recently from 15a7557 to ee4cac1 Compare March 24, 2026 13:41
@mjbear

mjbear commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

I'll work through this, but it would be simpler to review with one template per PR. 😇

@mjbear

mjbear commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

@k-ribot
Please regenerate the test data (yaml) with keys in alphabetical order.

@mjbear mjbear added the changes_requested Waiting on user to address feedback label Apr 1, 2026
@k-ribot
k-ribot force-pushed the add-mikrotik-routeros-interface-wireless-templates branch from ee4cac1 to 2ba40fc Compare July 13, 2026 12:49
@k-ribot
k-ribot force-pushed the add-mikrotik-routeros-interface-wireless-templates branch from 2ba40fc to 11973a3 Compare July 13, 2026 13:01
@k-ribot
k-ribot requested a review from mjbear July 13, 2026 13:01
@mjbear

mjbear commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Update to self:
Since the capture group regexes for the below items are \S+ (instead of \S*) the data must always be present in the test data.

  • MASTER_INTERFACE
  • SUPPORTED_RATES_B
  • BASIC_RATES_B
  • VHT_SUPPORTED_MCS
  • VHT_BASIC_MCS

@mjbear mjbear removed the changes_requested Waiting on user to address feedback label Aug 17, 2026
@matt852

matt852 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Recommendation: Changes Suggested

Breaking Change: No

Thanks @k-ribot — tests and yamllint are clean and every field in the raw output is captured. A few things before merge:

  • Widen the security-profile flags regex. A profile that is disabled carries an X flag, and the current regex only accepts the default *, so parsing fails on that row.

    In mikrotik_routeros_interface_wireless_security-profiles_print_terse_without-paging.textfsm:

    -Value FLAGS (\*)
    +Value FLAGS ([X*]+)

    The same class is already used in mikrotik_routeros_snmp_community_print_without-paging.textfsm.

  • Tighten the two HT MCS values to \S+. [^=]+ allows spaces, and every MCS value in the test data is a space-free comma list.

    In mikrotik_routeros_interface_wireless_print_terse_without-paging.textfsm:

    -Value HT_SUPPORTED_MCS ([^=]+)
    -Value HT_BASIC_MCS ([^=]+)
    +Value HT_SUPPORTED_MCS (\S+)
    +Value HT_BASIC_MCS (\S+)
  • Re-capture the two 3.raw fixtures from the device. In both of them the rows without a flag are missing the blank flag column that the flagged rows have, so name= starts two columns earlier. Your other fixtures (…without-paging.raw) show the padded form.

  • Drop the duplicate security-profile fixture. …security-profiles_print_terse_without-paging2.raw and its .yml are identical to the unnumbered pair, so they add no coverage — please delete them or swap in different output.

Thanks!
(review written by Claude)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants