Remove bulk workspace tools - #2045
Open
Aaronontheweb wants to merge 1 commit into
Open
Conversation
Aaronontheweb
force-pushed
the
refactor/remove-bulk-workspace-tools
branch
from
August 20, 2026 15:37
c7b7154 to
926fd1d
Compare
Aaronontheweb
added
cleanup
Aaronontheweb
force-pushed
the
refactor/remove-bulk-workspace-tools
branch
from
August 20, 2026 15:50
926fd1d to
ca4aadc
Compare
Aaronontheweb
commented
Aug 20, 2026
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Collaborator
Author
There was a problem hiding this comment.
Focused review of the tool-surface reduction.
| [NetclawTool(ToolName, | ||
| "Read several known text files atomically without shell. Every path is authorized before any content is returned.", | ||
| Grant = "file")] | ||
| public sealed partial class FileReadManyTool : NetclawTool<FileReadManyTool.Params> |
Collaborator
Author
There was a problem hiding this comment.
Compatibility checkpoint: this removes a public type. Please keep explicit release-history evidence in the PR description that no published package contains it; otherwise this needs a compatibility or deprecation plan.
| assert_tool_known_composed_read() { | ||
| local read_count | ||
| read_count=$(grep -aoE '\[tool:call\] file_read\(' "$STDOUT_FILE" 2>/dev/null | wc -l | tr -d ' ' || true) | ||
| [[ "$read_count" -eq 2 ]] \ |
Collaborator
Author
There was a problem hiding this comment.
This proves exactly two reads, both markers, and no shell fallback, but it does not prove the reads were issued in parallel or in the same tool batch. If the evidence claim is parallel composition, please assert that ordering/batch shape or narrow the claim to composability.
Aaronontheweb
force-pushed
the
refactor/remove-bulk-workspace-tools
branch
from
August 21, 2026 13:34
ca4aadc to
c19edbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json_readandfile_read_manytoolsfile_readcallsValidation
Evaluation scope
The deterministic eval contract was updated to remove the deleted JSON projection scenario. A hosted behavioral run was not repeated in this middle removal slice; the upper rollout-contract PR owns the refreshed model-facing evidence.
Stack
This is PR 2 of 3. Its base is PR #2044, now refreshed at
b103268b.