Skip to content

Test network addr#96

Closed
pappz wants to merge 5 commits intomainfrom
test/network-addr
Closed

Test network addr#96
pappz wants to merge 5 commits intomainfrom
test/network-addr

Conversation

@pappz
Copy link
Copy Markdown
Contributor

@pappz pappz commented Apr 16, 2026

Description

/testflight

Summary by CodeRabbit

  • Chores
    • Updated the netbird-core subproject to a newer internal revision to keep the codebase aligned with upstream updates and ensure the project uses the latest internal fixes and improvements.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2a4c5e11-9385-42f6-91be-12ec0c7edb55

📥 Commits

Reviewing files that changed from the base of the PR and between ac92235 and 71524a1.

📒 Files selected for processing (1)
  • netbird-core

📝 Walkthrough

Walkthrough

Updates the netbird-core submodule git reference from commit c1d1229ae0cb402fd4e16ee61f9f7c4652099b08 to 7bcb3f37ccb48e122fcb8d7d25af26f74bc485d6. No other code or configuration changes are present.

Changes

Cohort / File(s) Summary
Subproject Update
netbird-core
Updated submodule pointer from c1d1229ae0cb402fd4e16ee61f9f7c4652099b087bcb3f37ccb48e122fcb8d7d25af26f74bc485d6.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A tiny hop to a newer tree,
One hash swapped — how merrily!
Netbird-core now stepped ahead,
I nibble bytes on cozy thread,
Commit advanced — a joyful spree.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains '/testflight' with no actual description of the changes made. Required context about why the submodule was updated is completely missing. Add a meaningful description explaining the purpose of updating netbird-core, why link-local address filtering was added, and any relevant testing or implementation details.
Title check ❓ Inconclusive The title 'Test network addr' is vague and generic, using abbreviations that don't clearly convey what the changeset does despite being related to network address handling. Revise the title to be more specific and descriptive, such as 'Update netbird-core with link-local address filter' to clearly indicate the main change.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/network-addr
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch test/network-addr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@netbird-core`:
- Line 1: Update and verify the netbird-core submodule to the commit
7e4542adde54ebe71a3a47f5228c5915c9c1052a and test the iOS-specific fix: confirm
GetInfo() now populates NetworkAddresses so the peer_network_range_check posture
check behaves correctly; run iOS end-to-end flows exercising client, management,
and proxy behaviors, validate posture check pass/fail scenarios, and report any
regressions from the 29-commit delta (focus on GetInfo(), NetworkAddresses, and
peer_network_range_check).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 93d8f489-02bc-4b36-944e-95783ee812a7

📥 Commits

Reviewing files that changed from the base of the PR and between d3ed3b8 and 37b88fd.

📒 Files selected for processing (1)
  • netbird-core

Comment thread netbird-core Outdated
@github-actions
Copy link
Copy Markdown

Build failed (iOS) for 37b88fd

View workflow run

@pappz pappz changed the title Bump netbird-core version Test network addr Apr 16, 2026
@github-actions
Copy link
Copy Markdown

TestFlight builds uploaded (116) for 37b88fd — iOS + tvOS

View workflow run

@github-actions
Copy link
Copy Markdown

TestFlight builds uploaded (117) for ac92235 — iOS + tvOS

View workflow run

@github-actions
Copy link
Copy Markdown

TestFlight builds uploaded (120) for c385977 — iOS + tvOS

View workflow run

@github-actions
Copy link
Copy Markdown

TestFlight builds uploaded (132) for 63a7c0f — iOS + tvOS

View workflow run

@pappz pappz closed this Apr 20, 2026
@pappz pappz deleted the test/network-addr branch April 20, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant