Skip to content

Allow maintainers to trigger TestFlight from fork PRs#108

Merged
pappz merged 1 commit intomainfrom
feat/fork-pr-testflight
Apr 28, 2026
Merged

Allow maintainers to trigger TestFlight from fork PRs#108
pappz merged 1 commit intomainfrom
feat/fork-pr-testflight

Conversation

@evgeniyChepelev
Copy link
Copy Markdown
Collaborator

@evgeniyChepelev evgeniyChepelev commented Apr 28, 2026

Description

Allow trusted maintainers to trigger TestFlight builds from fork PRs via /testflight comment. Previously, all fork PRs were blocked unconditionally. Now the permission check (write/admin access required) serves as the explicit approval gate — equivalent to GitHub's "Approve and run" button.

Summary by CodeRabbit

  • Chores
    • Improved CI/CD workflow to streamline TestFlight build processing while maintaining necessary security permissions checks.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2a652e34-e65a-4d5c-9624-378613c6654c

📥 Commits

Reviewing files that changed from the base of the PR and between ab2a0d8 and bf50f62.

📒 Files selected for processing (1)
  • .github/workflows/testflight.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/testflight.yml

📝 Walkthrough

Walkthrough

The change removes a fork-origin validation check from the issue_comment handler in the TestFlight workflow. Previously, the handler would skip processing if the pull request originated from a fork. Now, after verifying the commenter has appropriate permissions, it proceeds directly to parsing the /testflight command without enforcing the fork constraint.

Changes

Cohort / File(s) Summary
TestFlight Workflow
.github/workflows/testflight.yml
Removed fork-PR blocking condition from issue_comment trigger; now processes /testflight commands from commenters with admin or write permissions regardless of fork origin.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • pappz

Poem

🐰 A fork once blocked the timely flight,
But permissions checked with care and might,
Now commands run straight and true,
For those with access through and through!
The workflow hops with simpler grace. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: allowing maintainers to trigger TestFlight builds from fork PRs, which directly reflects the removal of the fork-blocking check.
Description check ✅ Passed The description provides clear context about the change, explaining what was previously blocked, why it's now allowed, and how permission controls serve as approval. All key information is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/fork-pr-testflight

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pappz pappz merged commit 5cf7fed into main Apr 28, 2026
16 checks passed
@pappz pappz deleted the feat/fork-pr-testflight branch April 28, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants