docs: correct NX-OS Direct D2D credential env vars in PRD - #936
Merged
Conversation
3 tasks
The D2D credential table listed `NXOS_SSH_USERNAME`/`NXOS_SSH_PASSWORD` for the NX-OS Direct architecture. Those names appear nowhere in the codebase, and the NXOS entry in CONTROLLER_REGISTRY uses the bare `NXOS_` prefix, matching the IOS-XE Direct precedent (`IOSXE_USERNAME`/`IOSXE_PASSWORD`). The ACI and NDFC rows still show `NXOS_SSH_*` for leaf/spine SSH access. Those are equally unimplemented, but renaming them is a separate design decision about whether device credentials key off the device family or the controller context, so they are left as-is here. AI-Generated: yes AI-Tool: claude-code AI-Model: claude-opus-5 AI-Percent: 50 AI-Reason: documentation correction
ChristopherJHart
force-pushed
the
docs/prd-nxos-env-vars
branch
from
September 3, 2026 04:13
2a5a8f6 to
424885d
Compare
ChristopherJHart
changed the title
3 tasks
oboehmer
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the NX-OS Direct row in the D2D credential environment variable table in
dev-docs/PRD_AND_ARCHITECTURE.md. One line, documentation only.Problem
The table listed
NXOS_SSH_USERNAME/NXOS_SSH_PASSWORDfor the NX-OS Direct architecture. Those names appear nowhere in the codebase — a repo-wide grep across.py,.yaml, and.j2returns zero hits.The NXOS entry added to
CONTROLLER_REGISTRYin #895 uses the bareNXOS_prefix, following the IOS-XE Direct precedent:IOSXE_USERNAMEIOSXE_PASSWORDNXOS_SSH_USERNAMENXOS_SSH_PASSWORDNXOS_USERNAMENXOS_PASSWORDDeliberately left alone
The ACI and NDFC rows still show
NXOS_SSH_*for leaf/spine SSH access. Those are equally unimplemented, but renaming them decides whether device credentials key off the device family or the controller context — a design question rather than a consistency fix. Happy to fold it in if reviewers would rather settle it here.Test plan
NXOS_SSH_*has zero occurrences outside this documentRelated
CONTROLLER_REGISTRY, the code this row now matchesCONTROLLER_REGISTRYexample after feat(core): controller resolution refactor - single-source-of-truth #896 (was originally bundled into this PR; split out to keep the scopes independent)🤖 AI Generation Metadata