fix(plugin): normalize workspace package import paths in metadata generator#3798
Open
maruthang wants to merge 1 commit intonestjs:masterfrom
Open
fix(plugin): normalize workspace package import paths in metadata generator#3798maruthang wants to merge 1 commit intonestjs:masterfrom
maruthang wants to merge 1 commit intonestjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
PluginMetadataGenerator(viaModelClassVisitorandControllerClassVisitor) computes relative paths from the source directory to the physicalnode_modules/location of workspace packages. This produces import paths like../node_modules/@amk/utils/src/dto/order.dtoin the generated metadata, which causes TypeScript TS2742 errors at compile time.Issue Number: #3453
What is the new behavior?
A
normalizePackagePathhelper is extracted inplugin-utils.ts. It detects when a resolved path passes throughnode_modules/and strips everything up to that boundary, returning a bare package specifier (e.g.,@amk/utils/src/dto/order.dto). BothModelClassVisitorandControllerClassVisitornow use this helper in theircollectedMetadata()methods, so generated metadata always contains correct importable package paths.Does this PR introduce a breaking change?
Other information
7 new unit tests added in
test/plugin/normalize-package-path.spec.tscovering bare package paths, scoped packages, deep paths, and paths that should not be modified. All 152 tests pass.