fix(plugin): respect IsIn each option for array properties#3790
Open
y-hsgw wants to merge 2 commits intonestjs:masterfrom
Open
fix(plugin): respect IsIn each option for array properties#3790y-hsgw wants to merge 2 commits intonestjs:masterfrom
y-hsgw wants to merge 2 commits intonestjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2027
When using class-validator
@IsIn([...], { each: true })on an array property, the CLI plugin emits OpenAPI metadata withenumbut withoutisArray: true.As a result, the generated OpenAPI schema can treat the property as a scalar enum instead of an array of enum items.
What is the new behavior?
The CLI plugin now sets
isArray: truewhen it detects@IsIn(..., { each: true }), so the emitted OpenAPI metadata correctly represents an array of enum items.Regression tests were added/updated to cover this behavior.
Does this PR introduce a breaking change?
Other information