fix(decorators): do not crash on Controller getter#3788
Open
robbtraister wants to merge 1 commit intonestjs:masterfrom
Open
fix(decorators): do not crash on Controller getter#3788robbtraister wants to merge 1 commit intonestjs:masterfrom
robbtraister wants to merge 1 commit intonestjs:masterfrom
Conversation
getter descriptors use the `.get` field rather than `.value`. If an @ApiQuery-decorated Controller has a getter, we should ignore the getters when applying the decoration to its members. This change will prevent these types of Controllers from crashing on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getter descriptors use the
.getfield rather than.value. If an @ApiQuery-decorated Controller has a getter, we should ignore the getters when applying the decoration to its members.This change will prevent these types of Controllers from crashing on startup.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a controller is decorated with
@ApiQuery()and also contains a getter, the app will crash on startup.Issue Number: N/A
What is the new behavior?
When a controller is decorated with
@ApiQuery()and also contains a getter, the app will start as expected.Does this PR introduce a breaking change?