fix(plugin): handle non-ASCII characters in project paths#3786
Open
maruthang wants to merge 1 commit intonestjs:masterfrom
Open
fix(plugin): handle non-ASCII characters in project paths#3786maruthang wants to merge 1 commit intonestjs:masterfrom
maruthang wants to merge 1 commit intonestjs:masterfrom
Conversation
TypeScript URL-encodes non-ASCII chars in type import paths but the file system path stays un-encoded. This caused replaceImportPath to emit absolute paths instead of relative ones when the project directory contained non-ASCII characters. Decode URI components before computing relative paths. Closes nestjs#3695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
When the project is in a folder with non-ASCII characters (e.g., "testnéstcli"), the plugin generates absolute paths in compiled output instead of relative paths, causing "Cannot find module" errors at runtime.
Issue Number: #3695
What is the new behavior?
Added
safeDecodeURIComponent()to decode URL-encoded characters before computing relative paths inreplaceImportPath(). TypeScript URL-encodes non-ASCII chars in type references, but the filesystem path stays un-encoded — this mismatch causedposix.relative()to fail. 11 regression tests added.Does this PR introduce a breaking change?