fix(explorer): pass version to operationIdFactory for all versioning types#3783
Open
maruthang wants to merge 1 commit intonestjs:masterfrom
Open
fix(explorer): pass version to operationIdFactory for all versioning types#3783maruthang wants to merge 1 commit intonestjs:masterfrom
maruthang wants to merge 1 commit intonestjs:masterfrom
Conversation
…types operationIdFactory only received version for URI/path versioning. For HEADER, MEDIA_TYPE, and CUSTOM versioning, version was always undefined. Read version from @Version() decorator metadata or defaultVersion as fallback for non-URI versioning types. Closes nestjs#3268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
The
operationIdFactorycallback only receives theversionparameter when using URI/path versioning. For HEADER, MEDIA_TYPE, and CUSTOM versioning types, the version parameter is alwaysundefined.Issue Number: #3268
What is the new behavior?
Added
getNonPathVersion()method that reads version from the@Version()decorator metadata or falls back todefaultVersionfrom versioning options for non-URI versioning types. This version is passed togetOperationIdwhen no path-based version is found.5 regression tests added covering HEADER, MEDIA_TYPE, CUSTOM versioning types and the default operationIdFactory.
Does this PR introduce a breaking change?