feat: Add exclude as a complement to exclude.#1289
feat: Add exclude as a complement to exclude.#1289evantrimboli wants to merge 1 commit intonestjs:masterfrom
Conversation
|
@evantrimboli I would grateful if you would resolve conflicts to push it further. I also need this feature 🙂 |
|
The code here looks solid. If we can get the conflicts resolved I could see this being useful. |
|
Upon reflection I think this PR doesn't make sense as-is. I think it would be better to alter the type of include to: type IncludeFn = (module: Function) => boolean;
include?: IncludeFn | Function[]; |
Oh, even better with less complexity. I'm game for that |
|
Was this included on another PR or it was abandoned? |
|
Is it ready to merge after resolving the conflicts? |
Yeah I agree |
|
What's the status of this? |
|
I added an updated PR here: #3759 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#1288
Issue Number: 1288
What is the new behavior?
excludeworks as a complement toinclude.Does this PR introduce a breaking change?
Other information