Fix #2773: space key broken with KEYBOARD_LAYOUT_ES after tic_key_iso_extra removal - #2962
Open
joshgoebel wants to merge 1 commit into
Open
Fix #2773: space key broken with KEYBOARD_LAYOUT_ES after tic_key_iso_extra removal#2962joshgoebel wants to merge 1 commit into
joshgoebel wants to merge 1 commit into
Conversation
…ey_iso_extra removal Commit 1149e7c removed tic_key_iso_extra from the enum, shifting tic_key_space from index 49 to 48. This fixed the non-ES layout (Symbols[48] was already ' '), but broke KEYBOARD_LAYOUT_ES where Symbols[48] was '<' (the old ISO extra key), Shift[48] was '>', and Alt[48] was one past the last useful character. Remove the '<' and '>' from positions 48 in the ES Symbols and Shift arrays so that tic_key_space (48) now correctly maps to ' '. Also update the US KEYS reference comment to no longer show the '<'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2773
Commit 1149e7c (#2768) fixed baremetal space by removing
tic_key_iso_extra, shiftingtic_key_spaceto index 48. Non-ES builds were automatically fixed (the trailing' 'was already at index 48). ButKEYBOARD_LAYOUT_ESarrays still had</>at position 48 (the old ISO extra key slot), so ES builds got<for space and>for shift+space. ALT+Space still worked (explaining the workaround described in the issue).Fix: Remove
<fromSymbols[48]and>fromShift[48]in the ES layout sotic_key_space (48)correctly maps to' 'across all layouts. Also trimsAltby one character for consistency and updates the reference comment.