Skip to content

feat: add delay in between multiaction children#393

Open
KeryaneK wants to merge 3 commits into
nekename:mainfrom
KeryaneK:feature/delay_in_multiaction
Open

feat: add delay in between multiaction children#393
KeryaneK wants to merge 3 commits into
nekename:mainfrom
KeryaneK:feature/delay_in_multiaction

Conversation

@KeryaneK

@KeryaneK KeryaneK commented Jul 17, 2026

Copy link
Copy Markdown

Preflight checklist

If you remove this checklist, this pull request will be closed without explanation.

  • I understand that if this pull request is about support for non-Elgato or non-Tacto hardware, it will be closed without explanation, as per issue Statement regarding device support #38.
  • I certify the compliance of this pull request with the Jellyfin LLM/"AI" Development Policy adopted by the OpenDeck project.
  • I thoroughly understand the changes that I am proposing in this pull request, and I will be able to respond to questions and review feedback.
  • I reasonably believe that the changes that I am proposing are of production quality, or I am otherwise opening this pull request as a draft.
  • I have thoroughly reviewed the diff of my changes and ensured that I have neither introduced any unrelated additions, nor differences in unmodified code.
  • I have ensured that I have run the appropriate formatter on my changes and that my code produces no linter violations.
  • I will keep "Allow edits from maintainers" enabled for this pull request.

This PR introduces delays in multiaction. They're set to 0 by default to not break current user settings.
Also there are in-built delays - 100ms on keydown and 100ms on keyup. I haven't touched them as I'm not sure about their purpose. Delay settings are saved as an array in multiaction settings.

2026-07-18_12-39-10

@CLAassistant

CLAassistant commented Jul 17, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@KeryaneK
KeryaneK marked this pull request as draft July 17, 2026 15:31
@KeryaneK

Copy link
Copy Markdown
Author

I've updated it to use parent's action settings to not interfere with plugins.

@KeryaneK

Copy link
Copy Markdown
Author

Basic manual tests done:

  • settings do not override themselfs on update and reversion.
  • delay action shows only when it's needed ( >2 actions, not after the last, not before the first)
  • gaps are proper, even with delay actions in between them

Changing it to "Open" then although any improvement ideas are still welcome.

@KeryaneK
KeryaneK marked this pull request as ready for review July 18, 2026 10:09
@KeryaneK
KeryaneK force-pushed the feature/delay_in_multiaction branch from fe66a0c to d2eb542 Compare July 18, 2026 10:43
@KeryaneK

Copy link
Copy Markdown
Author

Force-push was about commit signing - no changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants