fix: Modify Popup.svelte to accept slots to render header and footer …#384
Open
fcrespo82 wants to merge 1 commit into
Open
fix: Modify Popup.svelte to accept slots to render header and footer …#384fcrespo82 wants to merge 1 commit into
fcrespo82 wants to merge 1 commit into
Conversation
…properly without scrolling off the screen
Collaborator
|
May I ask what your Reasoning is to change this Behaviour? |
Owner
|
Yeah, the changes look OK, but you need to provide a longer description of the change |
Author
|
Sorry for the low effort on the original description. I made it late at night and forgot to add the description. I've updated the original description for the PR. |
Collaborator
Could you please also add some before, after Pictures? |
Owner
|
Thanks, looks good! I'll look at this when I get back to OpenDeck stuff (who knows when) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves how popup windows are displayed across the app, especially in places like Settings, Plugins, Profile management, and Plugin details.
Previously, popup content could behave awkwardly when there was too much information on screen. Titles, close buttons, and footer content could scroll together with the rest of the popup, and in some cases footer text could overlap or sit on top of the main content.
With this change, popups have clearer sections: the top area stays reserved for the title and close button, the main content scrolls independently, and optional footer content stays separated from the scrollable area. This makes the popup layout more predictable and keeps important controls in a consistent place.
This does not add new user-facing features, but it improves the overall usability and polish of existing dialogs.
What Changed
Images
The settings one was taken with the inspector open to force the size to be able to see the difference.
Preflight checklist
If you remove this checklist, this pull request will be closed without explanation.