fix: always answer getSettings#377
Conversation
|
This is really weird. The only way that the event wouldn't be sent is if it was requesting settings for an action that didn't exist or if it's requesting settings for an action from a different plugin. Don't you think this is an issue that should be raised with the plugin developer first? If they refuse to fix it, then I can consider merging this. But I think you should at least ask them first. |
Yeah I'm drafting up a PR for there as well. It's odd that the windows StreamDeck software just will blindly do this, since it does offer potential wonkiness. |
Preflight checklist
If you remove this checklist, this pull request will be closed without explanation.
This makes
getSettingsalways reply even if we're in a fresh context. Some plugins, in my case https://github.com/ciderapp/CiderDeck, unconditionally expect this to reply (and it appears the official StreamDeck program does) and will get stuck in a crash loop when it doesn't exist.Once the plugin + OpenDeck are fully initialized it's fine, just initial boot dies.