Skip to content

fix: always answer getSettings#377

Open
mja00 wants to merge 2 commits into
nekename:mainfrom
mja00:fix/getsettings-unknown-context-hang
Open

fix: always answer getSettings#377
mja00 wants to merge 2 commits into
nekename:mainfrom
mja00:fix/getsettings-unknown-context-hang

Conversation

@mja00

@mja00 mja00 commented Jul 1, 2026

Copy link
Copy Markdown

Preflight checklist

If you remove this checklist, this pull request will be closed without explanation.

  • I understand that if this pull request is about support for non-Elgato or non-Tacto hardware, it will be closed without explanation, as per issue Statement regarding device support #38.
  • I certify the compliance of this pull request with the Jellyfin LLM/"AI" Development Policy adopted by the OpenDeck project.
  • I thoroughly understand the changes that I am proposing in this pull request, and I will be able to respond to questions and review feedback.
  • I reasonably believe that the changes that I am proposing are of production quality, or I am otherwise opening this pull request as a draft.
  • I have thoroughly reviewed the diff of my changes and ensured that I have neither introduced any unrelated additions, nor differences in unmodified code.
  • I have ensured that I have run the appropriate formatter on my changes and that my code produces no linter violations.
  • I will keep "Allow edits from maintainers" enabled for this pull request.

This makes getSettings always reply even if we're in a fresh context. Some plugins, in my case https://github.com/ciderapp/CiderDeck, unconditionally expect this to reply (and it appears the official StreamDeck program does) and will get stuck in a crash loop when it doesn't exist.

Once the plugin + OpenDeck are fully initialized it's fine, just initial boot dies.

@CLAassistant

CLAassistant commented Jul 1, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@nekename

nekename commented Jul 2, 2026

Copy link
Copy Markdown
Owner

This is really weird. The only way that the event wouldn't be sent is if it was requesting settings for an action that didn't exist or if it's requesting settings for an action from a different plugin. Don't you think this is an issue that should be raised with the plugin developer first?

If they refuse to fix it, then I can consider merging this. But I think you should at least ask them first.

@mja00

mja00 commented Jul 2, 2026

Copy link
Copy Markdown
Author

This is really weird. The only way that the event wouldn't be sent is if it was requesting settings for an action that didn't exist or if it's requesting settings for an action from a different plugin. Don't you think this is an issue that should be raised with the plugin developer first?

If they refuse to fix it, then I can consider merging this. But I think you should at least ask them first.

Yeah I'm drafting up a PR for there as well. It's odd that the windows StreamDeck software just will blindly do this, since it does offer potential wonkiness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants