Skip to content

fix(daemon): wait for async knowledge extraction before TempDir cleanup #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndzuki merged 1 commit into from
Sep 7, 2026
Merged

fix(daemon): wait for async knowledge extraction before TempDir cleanup #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/daemon/merge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ target_branch: %s

runner := newTestRunner(dir, filepath.Join(dir, "omp"), filepath.Join(dir, "logs"), 1)
runner.cfg.ObsidianVault = vault
// Merge completion can launch an async knowledge-extraction goroutine
// that writes under the fixture vault. Wait for it before TempDir
// cleanup, otherwise the cleanup races the write and flakes with
// "directory not empty" (Go 1.26 TempDir numbered subdirectories).
t.Cleanup(func() { waitForTasksIdle(t, runner) })
return &mergeFixture{
repo: repo,
worktree: worktree,
Expand Down