fix: Bolt 5のLambdaハンドラー形式に対応 - #76
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
Bolt 5(@slack/bolt v5.0.0)への追従と、Lambda ハンドラー呼び出し形式の差分を最小限で丁寧に合わせている点が良いです。CI/Infra 側でも Node.js 24 を利用しているため、Bolt 5 の Node.js 20+ 要件とも整合しており、アップデート方針として前向きに進められる内容です。
Changes:
@slack/boltを4.7.3→5.0.0に更新- Bolt 5 の AwsLambdaReceiver ハンドラー(2引数 Promise 形式)に合わせて
boltHandler(event, context)呼び出しへ変更 - 依存更新に伴う lockfile(
package-lock.json)の更新
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/handler.ts | Bolt 5 の Lambda ハンドラー呼び出しシグネチャ変更に追従(callback 引数の削除)。 |
| package.json | @slack/bolt を v5.0.0 に更新。 |
| package-lock.json | Bolt 5 および関連依存の解決結果を反映。 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
変更内容
@slack/boltを5.0.0へ更新確認したこと
npm run typecheckがTS2554で失敗することを確認npm run checknpm run typechecknpm test(36件成功)infraでnpx tsc --noEmitスクリーンショット
なし
補足事項
Renovate PR #75 の依存更新と、そのcheck失敗の修正を含みます。
PR時のセルフチェック