Update p031.py#51
Closed
AlkisPis wants to merge 1 commit intonayuki:masterfrom
Closed
Conversation
In the previous (last) code 1`) Combinations cannot be traced and 2) sums cannot be verified. Also the total number of coins used is arbitrarily set to 200, whereas the problem says "using any number of coins", i.e. why 200? Finally, and most importantly, the result seems wrong. I checked with TOTAL = 10. The solution given by the previous (last) code is 11, whereas the correct is 22, as shown with the proposed code below:
`
from itertools import combinations_with_replacement
cvs = [1, 2, 5, 10, 20, 50, 100, 200] # Coins and their values
TOTAL = 10 # Use 10 coins (for example)
count = 0 # Solutions (combinations) counter
tracing = True # Not necessary but used just for tracing the combinations
if tracing:
sol = [] # List with solutions
lst = sorted(list(combinations_with_replacement(cvs, TOTAL)))
for i in range(len(lst)):
if sum(lst[i]) == 200:
count += 1
if tracing:
sol.append(lst[i])
print("Total combinations:", count)
if tracing:
print("Solutions:", sol)
'''
Total solutions: 22
Solutions: [(1, 1, 1, 1, 1, 5, 20, 20, 50, 100), (1, 1, 1, 2, 5, 10, 10, 20, 50, 100), (1, 1, 1, 2, 5, 20, 20, 50, 50, 50), (1, 1, 2, 2, 2, 2, 20, 20, 50, 100), ...
(10, 10, 10, 20, 20, 20, 20, 20, 20, 50), (20, 20, 20, 20, 20, 20, 20, 20, 20, 20)]
Author
|
I don't get it. What about my proposition and the code I proposed? No comments or whatever? What happened to it? What happens to all propositions? If they are ignored, why do you ask for a proposition or Edit? |
Owner
|
Nowhere did I ask for people to edit my code. Please read my policies here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous (last) code 1`) Combinations cannot be traced and 2) sums cannot be verified. Also the total number of coins used is arbitrarily set to 200, whereas the problem says "using any number of coins", i.e. why 200? Finally, and most importantly, the result seems wrong. I checked with TOTAL = 10. The solution given by the previous (last) code is 11, whereas the correct is 22, as shown with the proposed code below:
`
from itertools import combinations_with_replacement