fix(qobuz): auto-refetch app id/secrets on stale credential error - #1031
Open
karolyi wants to merge 1 commit into
Open
fix(qobuz): auto-refetch app id/secrets on stale credential error#1031karolyi wants to merge 1 commit into
karolyi wants to merge 1 commit into
Conversation
Qobuz periodically rotates its app secret. A stale app_id/secret pair (hardcoded in the config, or cached from a previous run) still passes the lenient user/login check but fails secret validation against track/getFileUrl with a 400, surfacing as InvalidAppSecretError (or InvalidAppIdError) and a hard login failure. login() now splits into _attempt_login() and _refresh_app_id_and_secrets(). On InvalidAppIdError/InvalidAppSecretError it refetches a fresh pair from the web bundle, persists it to the config file, and retries once, so a secret rotation self-heals on the next run even when app_id/secrets are pinned in the config. Also relax the Pillow constraint to ">=9".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qobuz periodically rotates its app secret. A stale app_id/secret pair (hardcoded in the config, or cached from a previous run) still passes the lenient user/login check but fails secret validation against track/getFileUrl with a 400, surfacing as InvalidAppSecretError (or InvalidAppIdError) and a hard login failure.
login() now splits into _attempt_login() and _refresh_app_id_and_secrets(). On InvalidAppIdError/InvalidAppSecretError it refetches a fresh pair from the web bundle, persists it to the config file, and retries once, so a secret rotation self-heals on the next run even when app_id/secrets are pinned in the config.
Also relax the Pillow constraint to ">=9".