For each region, include metadata of main country for calling code#25
Open
dwbruhn wants to merge 2 commits intonathanhammond:masterfrom
Open
For each region, include metadata of main country for calling code#25dwbruhn wants to merge 2 commits intonathanhammond:masterfrom
dwbruhn wants to merge 2 commits intonathanhammond:masterfrom
Conversation
Owner
|
I'm going to delay landing this until you get a chance to get those built and played with since this lib has ~0 tests. |
Contributor
Author
|
@nathanhammond Sure thing! |
Contributor
Author
|
@nathanhammond If I were to add tests, do you care what test framework? |
Utilized libphonenumber-7.6.0
Owner
|
I don't have a preference. If you intend to test in a browser I'd nominate QUnit, if you intend to just run tests in Node I'd nominate Mocha. I use both on an approximate daily basis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. #23
(Will include the recompiled files when not on battery power. 😄 )