Skip to content

Replace cgi escape in WikiExtractor#88

Draft
Mirochill wants to merge 1 commit into
natasha:masterfrom
Mirochill:fix-86-drop-cgi-import
Draft

Replace cgi escape in WikiExtractor#88
Mirochill wants to merge 1 commit into
natasha:masterfrom
Mirochill:fix-86-drop-cgi-import

Conversation

@Mirochill

Copy link
Copy Markdown

Fixes #86.

Summary:

  • Replace the global cgi import in the bundled WikiExtractor with html.escape on Python 3.
  • Keep the Python 2 fallback on cgi.escape and preserve the previous quote=False escaping behavior.

Validation:

  • git diff --check
  • rg -n "\bcgi\b|cgi\.escape|html_escape" corus/third/WikiExtractor.py
  • Not run locally: tests/build/lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'cgi'

1 participant