Skip to content

Unify icon contributions and clarify supported formats#450

Open
brisvag wants to merge 11 commits intonapari:mainfrom
brisvag:fix/icon-contributions
Open

Unify icon contributions and clarify supported formats#450
brisvag wants to merge 11 commits intonapari:mainfrom
brisvag:fix/icon-contributions

Conversation

@brisvag
Copy link
Copy Markdown
Contributor

@brisvag brisvag commented Apr 3, 2026

This PR aims to unify a bit the manifest regarding icons, and to bring it more in line with what the underlying app-model accepts.

We actually "officially" support more things than appmodel (e.g: https urls), and I'm not sure whether we plan to keep these and handle the extra logic ourselves or what else to do. At least with this we start supporting dark/light for all icon fields.

Copy link
Copy Markdown
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems to have a circular import that in the tests.

Comment thread src/npe2/manifest/_validators.py Outdated
@brisvag
Copy link
Copy Markdown
Contributor Author

brisvag commented Apr 13, 2026

Since it's not reused, I just moved the validator to the model where it's needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.89%. Comparing base (26804e3) to head (af10fdb).

Files with missing lines Patch % Lines
src/npe2/manifest/schema.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #450      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%     
===========================================
  Files           37       37              
  Lines         2780     2785       +5     
===========================================
+ Hits          2780     2782       +2     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/npe2/manifest/schema.py Outdated
Comment thread src/npe2/manifest/contributions/_commands.py Outdated
Comment thread src/npe2/manifest/contributions/_submenu.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants