-
-
Notifications
You must be signed in to change notification settings - Fork 500
Simplify test dependant packages against napari #6336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Czaki
wants to merge
38
commits into
napari:main
Choose a base branch
from
Czaki:feature/test_against_napari
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b80d734
move clone to subdirectory
Czaki 43f16e2
constraint path
Czaki 80fddbc
try use $GITHUB_WORKSPACE
Czaki d247d90
try github.workspace
Czaki ed2cae1
re add version hack
Czaki f3fdb82
fix typo in wheel build workflow
Czaki c819f26
try workflow for test multiple napari version
Czaki c84a40a
add name
Czaki ab99a68
call from pull_request test
Czaki 20f1f1e
fix typo
Czaki 97b50bd
Merge branch 'main' into feature/test_against_napari
Czaki a6f3e00
add support for passing `command pre` using env variable
Czaki 488f998
fix indendation
Czaki d5985c4
remove deps
Czaki b846ae0
try to pass COMMAND PRE
Czaki a510ed9
use test branch
Czaki 0953d82
chek "\n"
Czaki 771bfc2
use path instead of name
Czaki 6278f75
use `main_test` branch
Czaki 6b8b896
parent directory
Czaki 0288780
try isolated mode
Czaki 45336fa
skip pip list
Czaki 5ddd2cc
proper tag for package
Czaki 69a72b8
use actions/checkout default mechanism
Czaki d95d1c2
fix selection of repository
Czaki e2191c9
fix testing on pull request
Czaki 7235c2c
add option to pass pytest path
Czaki 90b9b2f
bug reproduce
Czaki d63e82a
add aditional guard
Czaki 556e59d
protect package_to_test_ref
Czaki 07dcf13
fix default repository
Czaki efb5f0e
use v0.4.19.x branch
Czaki 2fdf740
pass extra args
Czaki 23ca86d
fix name
Czaki d143d37
try fetch tags
Czaki bcbacf6
better workflow name
Czaki e56aea3
pass PYTEST_EXTRA_ARGS
Czaki 3e44e70
Merge remote-tracking branch 'napari/main' into feature/test_against_…
Czaki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: Test external package compatibility against main and last release | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - ".github/workflows/reusable_tox_run.yml" | ||
| - ".github/workflows/test_external_package_compatibility.yml" | ||
| workflow_call: | ||
| inputs: | ||
| package_to_test: | ||
| required: false | ||
| type: string | ||
| default: "" | ||
| package_to_test_ref: | ||
| required: false | ||
| type: string | ||
| default: "" | ||
| python_version: | ||
| required: false | ||
| type: string | ||
| default: "3.10" | ||
| platform: | ||
| required: false | ||
| type: string | ||
| default: "ubuntu-latest" | ||
| backend: | ||
| required: false | ||
| type: string | ||
| default: "headless" | ||
| pytest_path: | ||
| required: false | ||
| type: string | ||
| default: "" | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Initial test | ||
| uses: ./.github/workflows/reusable_run_tox_test.yml | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - python: ${{ inputs.python_version }} | ||
| platform: ${{ inputs.platform }} | ||
| backend: ${{ inputs.backend }} | ||
| napari_version: "main_test" | ||
| - python: ${{ inputs.python_version }} | ||
| platform: ${{ inputs.platform }} | ||
| backend: ${{ inputs.backend }} | ||
| napari_version: "v0.4.19x_test" | ||
| with: | ||
| python_version: ${{ matrix.python }} | ||
| platform: ${{ matrix.platform }} | ||
| qt_backend: ${{ matrix.backend }} | ||
| coverage: no_cov | ||
| package_to_test: ${{ github.event_name == 'pull_request' && 'napari/npe2' || inputs.package_to_test == '' && github.repository || inputs.package_to_test }} | ||
| package_to_test_ref: ${{ github.event_name == 'pull_request' && 'main' || inputs.package_to_test_ref }} | ||
| napari_version: ${{ matrix.napari_version }} | ||
| pytest_path: ${{ inputs.pytest_path }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tlambert03 Here is the full list that could be specified.
It includes
backend,platform,python_versionandpytest_pathwherepytest_pathis passed as environment variable totoxand then placed inpytestcommand.