feat: facets for issues and alerts by rbjornstad · Pull Request #483 · nais/api

rbjornstad · 2026-06-30T14:26:17Z

Summary

Adds facets to IssueConnection and AlertConnection, giving clients distribution counts to build filter UIs without extra round-trips.

Changes

Issues — SQL-aggregate pattern

IssueConnection gains an optional facets field:

type IssueConnection {
  pageInfo: PageInfo!
  nodes: [Issue!]!
  edges: [IssueEdge!]!
  facets: IssueFacets
}

type IssueFacets {
  environments:  [StringFacetItem!]!
  severities:    [IssueSeverityFacetItem!]!
  resourceTypes: [IssueResourceTypeFacetItem!]!
  issueTypes:    [IssueTypeFacetItem!]!
}

New supporting types: IssueSeverityFacetItem, IssueResourceTypeFacetItem, IssueTypeFacetItem.

SQL – new FacetsForIssues aggregate query groups by (severity, resource_type, env, issue_type) and returns filtered_count per group. The scope params (scope_resource_type, scope_resource_name, scope_env) are applied in the outer WHERE so only groups that exist within the connection scope appear in the result; user filter params (env[], severity, issue_type, filter_resource_type, filter_resource_name) go inside COUNT(*) FILTER (...). Single extra DB query, executed only when facets is requested.
IssueConnection – changed from a type alias to a struct (like ActivityLogEntryConnection) carrying teamSlug, scope, and filter for lazy facet computation in the resolver.
IssueScope – separates the fixed resource context (set by the caller, e.g. application.issues fixes resourceType, resourceName, env) from the user-controlled IssueFilter. Scope params narrow the base dataset; filter params narrow the counted set.
ComputeFacets – sums filteredCount per dimension; dimension values with filteredCount = 0 are still present because the scope WHERE ensures every group that exists in the scope seeds the map.
All six Issues resolvers (team + five resource-level) updated.

Alerts — in-memory pattern

AlertConnection gains an optional facets field:

type AlertConnection {
  pageInfo: PageInfo!
  nodes: [Alert!]!
  edges: [AlertEdge!]!
  facets: AlertFacets
}

type AlertFacets {
  environments: [StringFacetItem!]!
  states:       [AlertStateFacetItem!]!
}

New supporting type: AlertStateFacetItem.

AlertConnection – changed from pagination.Connection to pagination.FacetableConnection, following the same pattern as applications, OpenSearch, and Valkey.
AlertFacets – computes environment and state distribution counts in-memory over all alerts in the connection. Uses sync.Once to avoid recomputing the filtered set.
Both Alerts resolvers (teamResolver, teamEnvironmentResolver) now use SortFilter.PaginatedList.

Tests

Issues — TestBuildFacets covers three cases:

Mixed rows with seeded zero-count values — correct aggregation
With filter — unmatched dimension values present with count 0
Empty input — empty slices, no panics

Alerts — TestAlertFacets_Environments and TestAlertFacets_States cover:

No filter — all counts match totals
Filter by a dimension — non-matching values present with count 0
Filter across dimensions — counts reflect intersection
Empty alerts — no facet items

Design choices

SQL-aggregate for issues, in-memory for alerts — issues live in the DB and can be numerous; alerts are fetched in full from an external source and already in memory, so in-memory counting is simpler and equally efficient.
Scope vs filter split — scope params narrow the base dataset (so only groups that exist in the connection scope appear), filter params narrow the counted set. This follows the activitylog pattern and ensures facet items are never missing due to the current filter.
resourceName is not a facet dimension — it is a free-text search field, not a categorical one.

Copilot

Pull request overview

Adds facet distributions to the Issues GraphQL connection so clients can build filter UIs (counts per environment/severity/resourceType/issueType) without additional round-trips, using a SQL aggregate query and lazy computation when facets is requested.

Changes:

Extends IssueConnection in the GraphQL schema with an optional facets field and introduces new facet item types.
Adds FacetsForIssues SQL aggregate query + issue.ComputeFacets/buildFacets to compute per-dimension counts.
Refactors the issues connection return type from pagination.Connection[Issue] to *issue.IssueConnection across resolvers and regenerates gqlgen/sqlc outputs.

Reviewed changes

Copilot reviewed 13 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/issue/queries/issue.sql	Adds `FacetsForIssues` aggregate query for grouped total/filtered counts.
internal/issue/queries.go	Changes `ListIssues` to return `*IssueConnection` carrying `teamSlug`/`filter`.
internal/issue/model.go	Replaces `IssueConnection` type alias with a struct; adds facet DTO types.
internal/issue/issuesql/querier.go	Adds `FacetsForIssues` to the sqlc querier interface.
internal/issue/issuesql/issue.sql.go	sqlc-generated implementation/types for `FacetsForIssues`.
internal/issue/facets.go	Implements `ComputeFacets` and `buildFacets` assembly/sorting logic.
internal/issue/facets_test.go	Unit tests for `buildFacets` behavior (seeded zeros, empty input).
internal/graph/schema/issues.graphqls	Adds `IssueConnection.facets` and new facet GraphQL types with descriptions.
internal/graph/issues.resolvers.go	Adds `IssueConnection` resolver for `facets`; updates Team issues return type.
internal/graph/applications.resolvers.go	Updates `Application.issues` resolver to return `*issue.IssueConnection`.
internal/graph/jobs.resolvers.go	Updates `Job.issues` resolver to return `*issue.IssueConnection`.
internal/graph/opensearch.resolvers.go	Updates `OpenSearch.issues` resolver to return `*issue.IssueConnection`.
internal/graph/sqlinstance.resolvers.go	Updates `SQLInstance.issues` resolver to return `*issue.IssueConnection`.
internal/graph/valkey.resolvers.go	Updates `Valkey.issues` resolver to return `*issue.IssueConnection`.
internal/graph/gengql/applications.generated.go	gqlgen updates for `Application.issues` returning `IssueConnection`.
internal/graph/gengql/jobs.generated.go	gqlgen updates for `Job.issues` returning `IssueConnection`.
internal/graph/gengql/opensearch.generated.go	gqlgen updates for `OpenSearch.issues` returning `IssueConnection`.
internal/graph/gengql/sqlinstance.generated.go	gqlgen updates for `SQLInstance.issues` returning `IssueConnection`.
internal/graph/gengql/teams.generated.go	gqlgen updates for `Team.issues` returning `IssueConnection`.
internal/graph/gengql/valkey.generated.go	gqlgen updates for `Valkey.issues` returning `IssueConnection`.
internal/graph/gengql/issues.generated.go	gqlgen adds `IssueConnectionResolver.Facets` and marshaling for new facet types.
internal/graph/gengql/root_.generated.go	gqlgen registers `IssueConnection` resolver root + complexity entries.

Files not reviewed (9)

internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/issues.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/opensearch.generated.go: Generated file
internal/graph/gengql/sqlinstance.generated.go: Generated file
internal/graph/gengql/teams.generated.go: Generated file
internal/graph/gengql/valkey.generated.go: Generated file
internal/issue/issuesql/issue.sql.go: Generated file
internal/issue/issuesql/querier.go: Generated file

Copilot

Pull request overview

Copilot reviewed 13 out of 22 changed files in this pull request and generated no new comments.

Files not reviewed (9)

internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/issues.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/opensearch.generated.go: Generated file
internal/graph/gengql/sqlinstance.generated.go: Generated file
internal/graph/gengql/teams.generated.go: Generated file
internal/graph/gengql/valkey.generated.go: Generated file
internal/issue/issuesql/issue.sql.go: Generated file
internal/issue/issuesql/querier.go: Generated file

Copilot

Pull request overview

Copilot reviewed 18 out of 28 changed files in this pull request and generated 1 comment.

Files not reviewed (10)

internal/graph/gengql/alerts.generated.go: Generated file
internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/issues.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/opensearch.generated.go: Generated file
internal/graph/gengql/sqlinstance.generated.go: Generated file
internal/graph/gengql/teams.generated.go: Generated file
internal/graph/gengql/valkey.generated.go: Generated file
internal/issue/issuesql/issue.sql.go: Generated file
internal/issue/issuesql/querier.go: Generated file

Copilot

Pull request overview

Copilot reviewed 18 out of 28 changed files in this pull request and generated no new comments.

Files not reviewed (10)

internal/graph/gengql/alerts.generated.go: Generated file
internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/issues.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/opensearch.generated.go: Generated file
internal/graph/gengql/sqlinstance.generated.go: Generated file
internal/graph/gengql/teams.generated.go: Generated file
internal/graph/gengql/valkey.generated.go: Generated file
internal/issue/issuesql/issue.sql.go: Generated file
internal/issue/issuesql/querier.go: Generated file

Introduces facets for the team issues query, following the SQL-aggregate pattern used by the activity log. Facets provide distribution counts across four dimensions to help narrow down results: - environments - severities - resourceTypes - issueTypes A new FacetsForIssues SQL query computes counts grouped by (severity, resource_type, env, issue_type) using a FILTER WHERE clause so that all possible values are seeded (with count 0 if unmatched) and the filtered counts reflect the current active filter.

Adds IssueFacets type to IssueConnection with four fields: environments, severities, resourceTypes, issueTypes Each field returns a list of facet items with count of matching issues. Counts respect the current filter but are computed across the full (unpaginated) result set. New GraphQL types: IssueFacets, SeverityFacetItem, ResourceTypeFacetItem, IssueTypeFacetItem All Issues resolvers (team + resource-level) now return *issue.IssueConnection so the connection carries the team slug and filter needed for lazy facet computation.

Address Copilot review feedback: - FacetsForIssues SQL: split scope params (resource_type, resource_name, env) into the outer WHERE clause so total_count reflects the actual connection scope, matching the activitylog FacetsForActivityTypes pattern. User filter params remain in COUNT(*) FILTER (...). - IssueConnection now carries a separate IssueScope for resource-level queries (application, job, opensearch, sqlinstance, valkey). Resource resolvers build the scope from the resource object instead of embedding it in IssueFilter. - Normalize empty environments slice to nil in ListIssues and ComputeFacets so that an empty []string{} does not produce an always-false ANY predicate.

…o IssueSeverityFacetItem and IssueResourceTypeFacetItem

…straints

…ations in issues.generated.go

Copilot

Pull request overview

Copilot reviewed 18 out of 28 changed files in this pull request and generated 2 comments.

Files not reviewed (10)

internal/graph/gengql/alerts.generated.go: Generated file
internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/issues.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/opensearch.generated.go: Generated file
internal/graph/gengql/sqlinstance.generated.go: Generated file
internal/graph/gengql/teams.generated.go: Generated file
internal/graph/gengql/valkey.generated.go: Generated file
internal/issue/issuesql/issue.sql.go: Generated file
internal/issue/issuesql/querier.go: Generated file

…ssue constraints" This reverts commit 10724c3.

Copilot

Pull request overview

Copilot reviewed 18 out of 28 changed files in this pull request and generated 1 comment.

Files not reviewed (10)

internal/graph/gengql/alerts.generated.go: Generated file
internal/graph/gengql/applications.generated.go: Generated file
internal/graph/gengql/issues.generated.go: Generated file
internal/graph/gengql/jobs.generated.go: Generated file
internal/graph/gengql/opensearch.generated.go: Generated file
internal/graph/gengql/sqlinstance.generated.go: Generated file
internal/graph/gengql/teams.generated.go: Generated file
internal/graph/gengql/valkey.generated.go: Generated file
internal/issue/issuesql/issue.sql.go: Generated file
internal/issue/issuesql/querier.go: Generated file

nais-team-app Bot added the graphql-review-required label Jun 30, 2026

rbjornstad requested a review from Copilot June 30, 2026 14:27

Copilot started reviewing on behalf of rbjornstad June 30, 2026 14:27 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread internal/issue/queries/issue.sql

Comment thread internal/graph/issues.resolvers.go

rbjornstad requested a review from Copilot June 30, 2026 14:52

Copilot started reviewing on behalf of rbjornstad June 30, 2026 14:52 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

rbjornstad marked this pull request as ready for review July 1, 2026 07:55

rbjornstad requested a review from a team as a code owner July 1, 2026 07:55

rbjornstad marked this pull request as draft July 1, 2026 08:09

rbjornstad changed the title ~~feat: facets for issues~~ feat: facets for issues and alerts Jul 1, 2026

rbjornstad requested a review from Copilot July 1, 2026 08:36

Copilot started reviewing on behalf of rbjornstad July 1, 2026 08:36 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread internal/issue/facets_test.go Outdated

rbjornstad requested a review from Copilot July 1, 2026 08:55

Copilot started reviewing on behalf of rbjornstad July 1, 2026 08:55 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

rbjornstad marked this pull request as ready for review July 1, 2026 09:02

rbjornstad added 6 commits July 1, 2026 11:02

feat(graph): add facets to AlertConnection

a714d94

test(alerts): add facets tests

d3edc3a

test(issue): fix misleading test case name in TestBuildFacets

de7c9e0

rbjornstad force-pushed the issue-facets branch from 6dabd21 to de7c9e0 Compare July 1, 2026 09:02

thokra-nav reviewed Jul 1, 2026

View reviewed changes

Comment thread internal/graph/schema/issues.graphqls Outdated

refactor(graph): rename SeverityFacetItem and ResourceTypeFacetItem t…

5f16765

…o IssueSeverityFacetItem and IssueResourceTypeFacetItem

thokra-nav approved these changes Jul 1, 2026

View reviewed changes

nais-team-app Bot removed the graphql-review-required label Jul 1, 2026

refactor(issue): remove IssueScope, use IssueFilter for all issue con…

10724c3

…straints

refactor: remove unnecessary blank lines and optimize variable declar…

186ac2f

…ations in issues.generated.go

rbjornstad requested a review from Copilot July 1, 2026 09:34

Copilot started reviewing on behalf of rbjornstad July 1, 2026 09:34 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread internal/issue/queries/issue.sql

Comment thread internal/issue/queries/issue.sql

rbjornstad added 2 commits July 1, 2026 11:49

Revert "refactor(issue): remove IssueScope, use IssueFilter for all i…

31947d6

…ssue constraints" This reverts commit 10724c3.

fix(issue): remove unused total_count from FacetsForIssues query

a8cc3f2

rbjornstad requested a review from Copilot July 1, 2026 10:02

Copilot started reviewing on behalf of rbjornstad July 1, 2026 10:02 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread internal/issue/queries/issue.sql

rbjornstad merged commit d9ab892 into main Jul 1, 2026
15 checks passed

rbjornstad deleted the issue-facets branch July 1, 2026 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: facets for issues and alerts#483

feat: facets for issues and alerts#483
rbjornstad merged 11 commits into
mainfrom
issue-facets

rbjornstad commented Jun 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rbjornstad commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Issues — SQL-aggregate pattern

Alerts — in-memory pattern

Tests

Design choices

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rbjornstad commented Jun 30, 2026 •

edited

Loading