Skip to content

Remove ingress metrics from GraphQL API #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbjornstad merged 3 commits into from
Jul 3, 2026
Merged

Remove ingress metrics from GraphQL API #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
886e2f2
Remove ingress metrics from GraphQL API
rbjornstad Jun 30, 2026
cdb46ca
Remove IngressMetrics struct from application models
rbjornstad Jun 30, 2026
10cda70
Remove ingress metrics integration tests
rbjornstad Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 0 additions & 85 deletions integration_tests/ingress_metrics.lua
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion internal/cmd/api/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ func ConfigureGraph(

setupContext := func(ctx context.Context) context.Context {
ctx = podlog.NewLoaderContext(ctx, podLogStreamer)
ctx = application.NewLoaderContext(ctx, watchers.AppWatcher, watchers.IngressWatcher, prometheusClient, log)
ctx = application.NewLoaderContext(ctx, watchers.AppWatcher, watchers.IngressWatcher, log)
ctx = bigquery.NewLoaderContext(ctx, watchers.BqWatcher)
ctx = bucket.NewLoaderContext(ctx, watchers.BucketWatcher)
ctx = job.NewLoaderContext(ctx, watchers.JobWatcher, watchers.RunWatcher)
Expand Down
21 changes: 0 additions & 21 deletions internal/graph/applications.resolvers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,24 +117,6 @@ func (r *ingressResolver) Type(ctx context.Context, obj *application.Ingress) (a
return application.GetIngressType(ctx, obj), nil
}

func (r *ingressResolver) Metrics(ctx context.Context, obj *application.Ingress) (*application.IngressMetrics, error) {
return &application.IngressMetrics{
Ingress: obj,
}, nil
}

func (r *ingressMetricsResolver) RequestsPerSecond(ctx context.Context, obj *application.IngressMetrics) (float64, error) {
return application.RequestsPerSecondForIngress(ctx, obj)
}

func (r *ingressMetricsResolver) ErrorsPerSecond(ctx context.Context, obj *application.IngressMetrics) (float64, error) {
return application.ErrorsPerSecondForIngress(ctx, obj)
}

func (r *ingressMetricsResolver) Series(ctx context.Context, obj *application.IngressMetrics, input application.IngressMetricsInput) ([]*application.IngressMetricSample, error) {
return application.SeriesForIngress(ctx, obj, input)
}

func (r *mutationResolver) DeleteApplication(ctx context.Context, input application.DeleteApplicationInput) (*application.DeleteApplicationPayload, error) {
if err := authz.CanDeleteApplications(ctx, input.TeamSlug); err != nil {
return nil, err
Expand Down Expand Up @@ -225,8 +207,6 @@ func (r *Resolver) DeleteApplicationPayload() gengql.DeleteApplicationPayloadRes

func (r *Resolver) Ingress() gengql.IngressResolver { return &ingressResolver{r} }

func (r *Resolver) IngressMetrics() gengql.IngressMetricsResolver { return &ingressMetricsResolver{r} }

func (r *Resolver) RestartApplicationPayload() gengql.RestartApplicationPayloadResolver {
return &restartApplicationPayloadResolver{r}
}
Expand All @@ -241,7 +221,6 @@ type (
applicationInstanceResolver struct{ *Resolver }
deleteApplicationPayloadResolver struct{ *Resolver }
ingressResolver struct{ *Resolver }
ingressMetricsResolver struct{ *Resolver }
restartApplicationPayloadResolver struct{ *Resolver }
updateApplicationPayloadResolver struct{ *Resolver }
)
Loading
Loading