Skip to content

fix(editor): Allow name parameters to be defined by AI#28763

Merged
MiloradFilipovic merged 1 commit intomasterfrom
ADO-5065-fix-fromai-name
Apr 21, 2026
Merged

fix(editor): Allow name parameters to be defined by AI#28763
MiloradFilipovic merged 1 commit intomasterfrom
ADO-5065-fix-fromai-name

Conversation

@MiloradFilipovic
Copy link
Copy Markdown
Contributor

Summary

  • Remove parameters.name from PATH_DENYLIST
  • Added legacy versions of toolWorkflow and toolVectorStore nodes to NODE_DENYLIST so they don't allow their name to be AI defined

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-5065
Fixes 28261

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Bundle Report

Changes will increase total bundle size by 30 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 45.76MB 30 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/worker-*.js -3.15MB 17.9kB -99.43%
assets/worker-*.js 3.15MB 3.17MB 17586.03% ⚠️
assets/users.store-*.js 30 bytes 1.06MB 0.0%

Files in assets/users.store-*.js:

  • ./src/features/ndv/parameters/utils/fromAIOverride.utils.ts → Total Size: 4.01kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Architecture diagram
sequenceDiagram
    participant User
    participant UI as Editor UI (NDV)
    participant Utils as FromAIOverride Utils
    participant Meta as Node Metadata Store

    User->>UI: Select Node in Editor
    UI->>UI: Render Node Parameters

    loop For each Parameter (e.g., "name", "description")
        UI->>Utils: makeOverrideValue(path, node)
        
        Utils->>Utils: Check PATH_DENYLIST
        Note over Utils: CHANGED: "parameters.name" is no longer<br/>in the global path denylist.

        alt path is in PATH_DENYLIST
            Utils-->>UI: Return null (Override disabled)
        else path is allowed
            Utils->>Meta: Get Node Type & Version
            Meta-->>Utils: { type, typeVersion }

            Utils->>Utils: Check NODE_DENYLIST (Type + Version)
            
            alt NEW: Node is Legacy Tool (e.g., toolWorkflow <= 2.1)
                Note over Utils: Prevents AI from overriding name when<br/>node identity relies on runtime param.
                Utils-->>UI: Return null (Override disabled)
            else Node is compatible
                Utils-->>UI: Return "fromAI" override configuration
                UI->>UI: Show "Define with AI" toggle for parameter
            end
        end
    end

    opt User enables AI definition
        User->>UI: Toggle "Define with AI"
        UI->>UI: Map parameter value to AI-generated content
    end
Loading

@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-runners 386.00 MB 386.00 MB 392.50 MB (σ 11.06) +0.0% -1.7%
docker-image-size-n8n 1269.76 MB 1269.76 MB 1273.60 MB (σ 10.49) +0.0% -0.3%

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 114.37 MB 114.41 MB 114.45 MB (σ 0.27) -0.0% -0.1%
memory-rss-baseline 291.98 MB 278.98 MB 289.99 MB (σ 41.20) +4.7% +0.7%

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 186.42 MB 186.52 MB 186.43 MB (σ 0.26) -0.0% -0.0%
instance-ai-rss-baseline 383.88 MB 389.20 MB 366.52 MB (σ 22.66) -1.4% +4.7%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

@n8n-assistant n8n-assistant Bot added the n8n team Authored by the n8n team label Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Instance AI Workflow Eval Results

8/8 built | 17/27 passed (62%)

Workflow Build Passed
Create a workflow that handles contact form submissions via a webhook. 3/5
Get all the Linear issues created in the last 2 weeks. Filter them for 4/5
Every day, get the posts made in the past day on 3 different Slack cha 3/5
Create a form that collects: name, email, company, and interest level 2/2
Every day, fetch all open GitHub issues from repository 'acme-corp/bac 0/2
Create a workflow that receives webhook notifications with a JSON body 3/3
Fetch the latest posts from the JSONPlaceholder API (GET https://jsonp 1/3
Every hour, check the current weather for London, New York, and Tokyo 1/2
Failure details

partial-action-failure [builder_issue]

The Telegram node failed with 'Bad request - please check your parameters' (triggered by the mock returning a 400 'chat not found' error). Because the three downstream actions (Send Auto-Reply Email,

invalid-email [builder_issue]

The workflow crashed at the 'Send Auto-Reply Email' node with 'Invalid email address (item 0)' because the Gmail node validated the recipient address 'not-an-email' and threw an unhandled error. Since

multi-team-creator [builder_issue]

The checklist requires that Alice's AI issue is excluded from the cross-team report. However, the Filter Cross-Team Issues node uses a hardcoded teamMap that maps [email protected] to only 'Frontend'

channel-not-found [builder_issue]

The workflow crashed entirely when 'Get #product History' returned a channel_not_found error. The error propagated up and halted the entire workflow — 'Tag product', 'Merge All Channels', 'Format Mess

insufficient-permissions [builder_issue]

The workflow crashed entirely when 'Get #product History' returned a 403 error. The error propagated and caused the entire workflow execution to fail with 'Request failed with status code 403'. No err

happy-path [builder_issue]

The workflow failed to execute due to a misconfigured 'Split Issues' node. The node's 'fieldToSplitOut' parameter is an empty string, but this field is required. As a result, the execution failed imme

no-bugs [builder_issue]

The workflow failed to execute cleanly. The 'Split Issues' node has a misconfigured 'fieldToSplitOut' parameter (empty string), which caused the execution to fail with 'The workflow has issues and can

happy-path [mock_issue]

The workflow executed without errors, the Slack message was posted to #api-digest, and none of the listed titles contain 'qui'. However, the count and title list are incorrect. The Filter node correct

all-filtered [builder_issue]

The Filter Out 'qui' Titles node was supposed to filter OUT posts containing 'qui' in the title, but its output includes all 3 items — all of which contain 'qui'. The filter condition uses 'notContain

happy-path [mock_issue]

Multiple criteria from the checklist are not met:

  1. New York weather API call did not succeed: The Weather - New York mock failed with _evalMockError: true (mock generation failed with a JSON

@MiloradFilipovic MiloradFilipovic added this pull request to the merge queue Apr 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 21, 2026
@MiloradFilipovic MiloradFilipovic added this pull request to the merge queue Apr 21, 2026
Merged via the queue into master with commit 76358a6 Apr 21, 2026
100 of 104 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-5065-fix-fromai-name branch April 21, 2026 12:04
@n8n-assistant n8n-assistant Bot mentioned this pull request Apr 28, 2026
@n8n-assistant
Copy link
Copy Markdown
Contributor

n8n-assistant Bot commented Apr 28, 2026

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$fromAI button not shown for fields with parameter name "name" in AI Agent tool mode

2 participants