fix: Additional keys in routing nodes#28758
Merged
michael-radency merged 4 commits intoApr 21, 2026
Merged
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant Engine as Workflow Execution Engine
participant RN as RoutingNode (Declarative REST)
participant Utils as Context Utils
participant Eval as Expression Evaluator
participant API as External Service API
Note over Engine, API: Node Execution Flow (Declarative REST API)
Engine->>RN: execute()
RN->>Utils: NEW: getAdditionalKeys(additionalData, mode, runExecutionData)
Note right of Utils: Retrieves $execution.id, $workflow, etc.
Utils-->>RN: additionalKeys context
rect rgb(240, 240, 240)
Note over RN, Eval: Request Construction Phase
opt Resolve requestDefaults
RN->>Eval: CHANGED: resolve(template, { ...additionalKeys, $credentials, $version })
Eval-->>RN: Resolved defaults (BaseURL, Headers)
end
loop For each node property (parameter)
RN->>RN: Get parameter value
RN->>Eval: CHANGED: resolve(routing.url, { ...additionalKeys, $value, $version })
Eval-->>RN: Resolved Request Options
opt Property is "options" type
RN->>Eval: CHANGED: resolve(option.routing, { ...additionalKeys, $value, $version })
Eval-->>RN: Merged Request Options
end
end
end
RN->>API: Perform HTTP Request (with resolved options)
API-->>RN: Response Data
RN-->>Engine: Output NodeExecutionData
Contributor
Performance ComparisonComparing current → latest master → 14-day baseline Idle baseline with Instance AI module loaded
Memory consumption baseline with starter plan resources
docker-stats
How to read this table
|
mfsiega
reviewed
Apr 21, 2026
Contributor
mfsiega
left a comment
There was a problem hiding this comment.
LGTM, but I don't have much context on the code itself. Just two small questions on testing:
- Does this test fail without the code changes?
- Have you tested it manually on the issue that was originally reported?
Contributor
Author
@mfsiega
|
Merged
Contributor
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes missing additional keys in routing nodes
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)