Skip to content

fix: Filter out disabled AI Agent tool parents when mapping connected tools #28743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dom-Tursini wants to merge 1 commit into from
+33 −0
Closed

fix: Filter out disabled AI Agent tool parents when mapping connected tools #28743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/@n8n/nodes-langchain/utils/tests/helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,39 @@ describe('getConnectedTools', () => {
});
});

it('should ignore disabled parent tool nodes when mapping source node metadata', async () => {
const mockParentNodes = [
{ name: 'RegularTool', type: 'test', typeVersion: 1, disabled: false },
{ name: 'Disabled Tool', type: 'test', typeVersion: 1, disabled: true },
{ name: 'MCP Client Tool', type: 'test', typeVersion: 1, disabled: false },
];
const mockTools = [
{ name: 'tool1', description: 'desc1' },
new StructuredToolkit([
{ name: 'toolkitTool1', description: 'toolkitToolDesc1' },
{ name: 'toolkitTool2', description: 'toolkitToolDesc2' },
] as any),
];

mockExecuteFunctions.getInputConnectionData = jest.fn().mockResolvedValue(mockTools);
mockExecuteFunctions.getParentNodes = jest.fn().mockReturnValue(mockParentNodes);

const tools = await getConnectedTools(mockExecuteFunctions, false);

expect(tools[0].metadata).toEqual({
isFromToolkit: false,
sourceNodeName: 'RegularTool',
});
expect(tools[1].metadata).toEqual({
isFromToolkit: true,
sourceNodeName: 'MCP Client Tool',
});
expect(tools[2].metadata).toEqual({
isFromToolkit: true,
sourceNodeName: 'MCP Client Tool',
});
});

it('should preserve existing metadata when adding toolkit metadata', async () => {
const mockParentNodes = [{ name: 'MCP Client Tool' }];
const mockTools = [
Expand Down