Skip to content

feat(core): Disable computer-use auto-connect daemon (no-changelog)#28730

Closed
Cadiac wants to merge 1 commit intomasterfrom
instance-ai-dont-connect-localhost
Closed

feat(core): Disable computer-use auto-connect daemon (no-changelog)#28730
Cadiac wants to merge 1 commit intomasterfrom
instance-ai-dont-connect-localhost

Conversation

@Cadiac
Copy link
Copy Markdown
Contributor

@Cadiac Cadiac commented Apr 20, 2026

Summary

Do we want to have the auto-connect daemon enabled right now - we spoke last week that maybe not (yet)?
Maybe we could make this something opt-in, or have it enable only when user does some action like clicks on some connect button so that they expect it?

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/INS-108

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

@Cadiac Cadiac requested a review from dlavrenuek April 20, 2026 16:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Bundle Report

Changes will decrease total bundle size by 1.45kB (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 45.77MB -1.45kB (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/worker-*.js 3.15MB 3.17MB 17586.03% ⚠️
assets/worker-*.js -3.15MB 17.9kB -99.43%
assets/instanceAiSettings.store-*.js -1.45kB 14.28kB -9.22%

Files in assets/instanceAiSettings.store-*.js:

  • ./src/features/ai/instanceAi/instanceAiSettings.store.ts → Total Size: 9.64kB

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...features/ai/instanceAi/instanceAiSettings.store.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-rss-baseline 219.28 MB 288.44 MB 290.51 MB (σ 41.09) -24.0% -24.5% ⚠️
memory-heap-used-baseline 115.21 MB 114.39 MB 114.37 MB (σ 0.40) +0.7% +0.7% 🔴

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-n8n 1269.76 MB 1300.48 MB 1273.86 MB (σ 10.81) -2.4% -0.3%
docker-image-size-runners 386.00 MB 412.00 MB 392.93 MB (σ 11.30) -6.3% -1.8%

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 187.20 MB 186.88 MB 186.42 MB (σ 0.27) +0.2% +0.4% 🔴
instance-ai-rss-baseline 340.47 MB 386.52 MB 364.63 MB (σ 22.57) -11.9% -6.6% ⚠️
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

@n8n-assistant n8n-assistant Bot added the n8n team Authored by the n8n team label Apr 20, 2026
@dlavrenuek
Copy link
Copy Markdown
Contributor

@elsmr is working on moving the connection block to the chat - I would also expect that we would have the enabled/disabled polling functionality with his changes. So I would wait with this one.

@Cadiac
Copy link
Copy Markdown
Contributor Author

Cadiac commented Apr 21, 2026

todays release happened already anyways, and that version will unexpectedly prompt the user to allow these connections.

@Cadiac Cadiac closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants