Fix: MCP Server Trigger reading 'getWebhookName'?!?#28727
Open
shahyashish wants to merge 1 commit inton8n-io:masterfrom
Open
Fix: MCP Server Trigger reading 'getWebhookName'?!?#28727shahyashish wants to merge 1 commit inton8n-io:masterfrom
shahyashish wants to merge 1 commit inton8n-io:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In n8n trigger nodes, the webhook method receives its execution context (of type IWebhookFunctions) via the 'this' binding rather than as a function argument. By declaring the method with 'context: IWebhookFunctions' as a parameter, the context variable was left undefined when called by the n8n core, resulting in the reported TypeError. The fix updates the method signature to use 'this: IWebhookFunctions' and assigns it to a local 'context' variable to resolve the issue while maintaining compatibility with the rest of the method's logic.
Test: 1. Configure an MCP Server Trigger node in an n8n workflow.
2. Set a path (e.g. 'mcp-server') and Authentication to 'None'.
3. Activate the workflow.
4. Use a tool like 'curl' to make a GET request to the node's setup URL (e.g., http://localhost:5678/rest/oauth2-webhooks/mcp-server/sse).
5. Verify that the request no longer results in a 500 error and the n8n logs do not show the 'Cannot read properties of undefined (reading 'getWebhookName')' error.