-
Notifications
You must be signed in to change notification settings - Fork 13
Feature/simple custom proxy domain #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.5.x
Are you sure you want to change the base?
Changes from 18 commits
1859682
c660f3d
830868e
f82d195
ee3ff1a
17dd727
f3fa4b4
bd2ecb2
29bcfa4
97804ec
6582f60
0241a4e
e13be5a
9a4bf43
cac212c
3c7ac04
283b292
adeb1b3
1b9e48b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,8 @@ | |
| "files-bin": [ | ||
| "home/service/logger/.env", | ||
| "home/service/mail/.env", | ||
| "home/service/proxy/.env" | ||
| "home/service/proxy/.env", | ||
| "home/service/tracing/.env" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. home/service/tracing/.env already exists in the source tree and is required by home/service/tracing/docker-compose.yml because Compose reads TRAEFIK_NETWORK from that file. The phar packaging explicitly whitelists hidden .env files, but tracing was missing from that list. As a result, an installed ws could create ~/.my127/workspace/service/tracing/ without .env, causing |
||
| ], | ||
| "blacklist": [ | ||
| "tools/scripts/compile.sh", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives internal service wrappers a deterministic way to call back into the same
wsexecutable that launched the current command.Without it, nested calls inside
ws-service/ service init scripts would fall back to resolvingwsfromPATH, which can pick a different installed version. That is especially risky during tests, local branch validation, or when multiplewsbinaries exist on the machine.