feat: support 1password secret references for the AES key - #835
Open
mvisonneau wants to merge 1 commit into
Open
feat: support 1password secret references for the AES key#835mvisonneau wants to merge 1 commit into
mvisonneau wants to merge 1 commit into
Conversation
mvisonneau
force-pushed
the
feat/1password-secret-references
branch
from
September 2, 2026 16:59
08cb319 to
a02f218
Compare
Storing the AES key in a shell profile or an environment variable means keeping it in plaintext. Any value that starts with `op://` is now treated as a 1Password secret reference and resolved at runtime through the `op` CLI, so only the (non sensitive) reference needs to be stored: export S5_AES_KEY="op://Private/s5/credential" 1Password unlocks the value the way it is configured to: biometrics or the desktop app when working interactively, OP_SERVICE_ACCOUNT_TOKEN when running unattended. Values that do not start with `op://` keep being used as-is, making this entirely opt-in. The resolution happens in a dedicated package, behind a helper which can be reused for the other secrets s5 handles (eg: the Vault token) later on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mvisonneau
force-pushed
the
feat/1password-secret-references
branch
from
September 2, 2026 17:03
a02f218 to
11aca0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing the AES key in a shell profile or an environment variable means keeping it in plaintext. Any value that starts with
op://is now treated as a 1Password secret reference and resolved at runtime through theopCLI, so only the (non sensitive) reference needs to be stored:export S5_AES_KEY="op://Private/s5/aes-key"
1Password unlocks the value the way it is configured to: biometrics or the desktop app when working interactively, OP_SERVICE_ACCOUNT_TOKEN when running unattended. Values that do not start with
op://keep being used as-is, making this entirely opt-in.The resolution happens in a dedicated package, behind a helper which can be reused for the other secrets s5 handles (eg: the Vault token) later on.