Remove CUDA syncs from circular buffer#1031
Merged
kevinzakka merged 2 commits intoMay 29, 2026
Merged
Conversation
kevinzakka
approved these changes
May 29, 2026
Collaborator
Author
|
Ok, got some results for the Go1 velocity task. Here's what I get on #1020 for the Go1 task (with no actuator delay, as is the default): If I set a pretty significant drop in environment SPS. With this PR on top of yours, I get: i.e. recovering about half of the performance loss. |
79a1b4e to
6486621
Compare
Qingxiaoming
pushed a commit
to Qingxiaoming/mjlab
that referenced
this pull request
Jun 18, 2026
* Remove CUDA syncs from circular buffer * ruff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some CUDA profiling of our RL environments and found some surprising CUDA syncs associated with actuator delays. I tracked them down to these two places in
circular_buffer.py, in which the attempt to skip an unnecessary op actually slowed things down by forcing a CUDA sync. Note that I'm still pretty new to this; I'm just following https://docs.nvidia.com/dl-cuda-graph/torch-cuda-graph/sync-free-code.htmlIn our internal example, I got a ~3% speedup from this change, though I suspect the effect size will vary a lot based on whether the rest of the MDP is sync-free.
@kevinzakka I'll try to run your benchmarks from #1020