Skip to content

modules for new gbcms - #259

Merged
buehlere merged 9 commits into
developfrom
feature/gbcmsrs
Aug 27, 2026
Merged

modules for new gbcms#259
buehlere merged 9 commits into
developfrom
feature/gbcmsrs

Conversation

@buehlere

@buehlere buehlere commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

PR checklist

Closes #XXX

  • These are the modules for gbcms re-written in python and rust
  • Check to see if a nf-core module, or subworkflow is available and usable for your pipeline.
  • Feature branch is named feature/<module_name> for modules, or feature/<subworkflow_name> for subworkflows. For modules, if there is a subcommand use: feature/<module_name>/<module_subcommand>.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs.
  • Use nf-core data if possible for nf-tests. If not, use or add test data to mskcc-omics-workflows/test-datasets, following the repository guidelines, for nf-tests. Finally, if neither option is feasible, only add a stub nf-test.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label.
  • Use Jfrog if possible to fulfill software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile docker
      • nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile singularity
      • nf-core modules --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <module_branch> test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows --git-remote https://github.com/mskcc-omics-workflows/modules.git -b <subworkflow_branch> test <SUBWORKFLOW> --profile conda

@buehlere
buehlere requested a review from a team as a code owner August 25, 2026 15:18
@buehlere
buehlere requested a review from rhshah August 25, 2026 15:21

@rhshah rhshah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Eric! Thanks so much for all your work on this. And the last thought, for the stub version, instead of hardcoding the version, we could actually pull it from the container tag. Since the tag is already in the file (in the container line), and we have access to task.container in the stub block, it might be a smoother approach. Let me know what you think!

Comment thread modules/msk/gbcmsrs/buildgtfcache/environment.yml
Comment thread modules/msk/gbcmsrs/dna/tests/main.nf.test Outdated
Comment thread modules/msk/gbcmsrs/rna/main.nf
Comment thread modules/msk/gbcmsrs/dna/main.nf Outdated
Comment thread modules/msk/gbcmsrs/dna/meta.yml
Comment thread modules/msk/gbcmsrs/buildgtfcache/main.nf Outdated
real test data, fix sample names, add cache input for rna, other cleanup
@buehlere
buehlere requested review from nikhil and rhshah August 26, 2026 18:28

@nikhil nikhil left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@buehlere
buehlere merged commit d6de396 into develop Aug 27, 2026
17 checks passed
@buehlere
buehlere deleted the feature/gbcmsrs branch August 27, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants