fix(plugin): clean orphaned legacy engineer payloads - #926
Merged
Conversation
kaitranntt
commented
Jul 14, 2026
kaitranntt
left a comment
Collaborator
Author
There was a problem hiding this comment.
Maintainer review\n\nSummary: Repairs metadata-pruned legacy Engineer payloads using official cache provenance and exact same-path byte matches, then routes the result through existing convergence.\n\nRisk: Medium scope, low residual risk.\n\nMandatory gates\n- Duplicate/prior implementation: clear; #891 and #911 are predecessor work, not duplicates.\n- Project standards: followed.\n- Strategic necessity: clear reliability and support-toil reduction.\n\nFindings: No Critical or Important findings.\n\nValidation: 172 focused tests passed; full local CI passed with 5,326 tests and 65 skips; typecheck, lint, builds, package verification, Gitleaks, and all three GitHub checks passed. PR is mergeable and CLEAN against .\n\nVerdict: Approve.\n\nPosted by /ck:review-pr at 2026-07-14T06:20:00Z
Collaborator
Author
|
Review correction: PR is mergeable and CLEAN against dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #925
Root cause
Plugin install-mode detection relied on metadata ownership history. After that ownership was pruned, restored flat Engineer files became invisible even when they were byte-identical to files from a known ClaudeKit plugin cache, allowing stale copied payloads to coexist with plugin mode.
Summary
ckcache manifests with matching versions and exact same-path bytesTest plan
bun run ci:local(5,326 pass, 65 skip, 0 fail)Docs impact: none — internal repair and safety behavior; commands unchanged.