Bug 1846013 Allow users to fetch results from all frameworks - #9815
Conversation
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| base_sig_id = base_sig.get("id", None) | ||
| new_sig = comparison_inputs.new.signatures_map.get(sig_identifier, {}) | ||
| new_sig_id = new_sig.get("id", None) | ||
| sig_framework_id = base_sig.get("framework_id") or new_sig.get("framework_id") |
There was a problem hiding this comment.
Here:
-
When a framework is provided, base and new signatures are filtered to it, so they always share that framework, so
oroperation is benign. -
When omitted (all frameworks), the comparison key doesn't include the framework, so the two sides can potentially differ and this matters for creating the graph links since it'll use one framework for both new/base.
I can try and create the graphs individually? Or another solution?
|
|
||
|
|
||
| # Flag to denote that we should return results for all frameworks | ||
| LIST_ALL_FRAMEWORKS = -1 |
There was a problem hiding this comment.
Using -1 since PKs cannot be negative (unless we set it manually but i didn't see anything related to that here - please correct me if I'm wrong). And in the frontend we can map an "all" option to -1, so we don't have to update the serializers on the backend as well. This solves :sparky comment about using all string.
1 participant
Bug: API - make framework parameter optional
Note: This is a rewrite of #9761 since I mest up the git history there and found it easier to close and start a new one with the requested changes here.