Skip to content

Bug 2064659 - Graphs View: Add a checkbox to HighlightOptionsDropdown to indicate that multiple options can be selected at once #9796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmiculit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug 2064659 - Graphs View: Add a checkbox to HighlightOptionsDropdown to indicate that multiple options can be selected at once #9796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions ui/perfherder/graphs/HighlightOptionsDropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const HighlightOptionsDropdown = ({
];

return (
<Dropdown className="me-0 text-nowrap" title="Highlight Options Dropdown">
<Dropdown className="me-0 text-nowrap">
<Dropdown.Toggle
variant="secondary"
aria-label="Highlight Options Dropdown"
Expand All @@ -47,15 +47,23 @@ const HighlightOptionsDropdown = ({
<Dropdown.Item
key={key}
as="button"
className="d-flex align-items-center"
onClick={() => updateStateParams({ [key]: !isChecked })}
role="menuitemcheckbox"
aria-checked={isChecked}
>
{isChecked && (
<FontAwesomeIcon
icon={faCheck}
className="me-2"
title="Selected"
/>
)}
<span
className="border border-secondary rounded me-2 d-flex align-items-center justify-content-center"
style={{ width: '18px', height: '18px' }}
aria-hidden="true"
>
{isChecked && (
<FontAwesomeIcon
icon={faCheck}
style={{ fontSize: '12px' }}
/>
)}
</span>
{label}
</Dropdown.Item>
))}
Expand Down