Skip to content

[bug-2059493] Remove unneeded MWU attributes from serializer #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gopar wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −163
Open

[bug-2059493] Remove unneeded MWU attributes from serializer #9794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 0 additions & 143 deletions tests/webapp/api/test_perfcompare_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,6 @@ def test_perfcompare_results_with_mann_witney_u_against_no_base(
f"series={try_repository.name}%2C{base_sig.signature_hash}%2C1%2C{base_sig.framework.id}&"
f"series={test_repository.name}%2C{base_sig.signature_hash}%2C1%2C{base_sig.framework.id}&"
f"timerange=86400",
"is_fit_good": True,
"is_meaningful": True,
"is_new_better": None,
"base_parent_signature": response["base_parent_signature"],
Expand Down Expand Up @@ -1335,11 +1334,7 @@ def test_perfcompare_results_with_mann_witney_u_against_no_base(
"Shapiro-Wilk test cannot be run on Base with fewer than 3 data points.",
"Shapiro-Wilk test cannot be run on New with fewer than 3 data points.",
],
"warning_c_delta": None,
"kde_warnings": [],
"more_runs_are_needed": False,
"silverman_kde": None,
"silverman_warnings": [],
},
]

Expand All @@ -1362,138 +1357,6 @@ def test_perfcompare_results_with_mann_witney_u_against_no_base(
assert response.json()[0]["new_parent_signature"] is None


def test_perfcompare_results_with_silverman_kde_enabled(
client,
create_signature,
test_perf_signature,
test_repository,
try_repository,
eleven_jobs_stored,
test_perfcomp_push,
test_perfcomp_push_2,
test_linux_platform,
test_option_collection,
):
"""Test that enabling silverman_kde parameter includes KDE analysis in response"""
perf_jobs = Job.objects.filter(pk__in=range(1, 11)).order_by("push__time").all()

test_perfcomp_push.time = FOUR_DAYS_AGO
test_perfcomp_push.repository = try_repository
test_perfcomp_push.save()
test_perfcomp_push_2.time = datetime.datetime.now()
test_perfcomp_push_2.save()

suite = "a11yr"
test = "dhtml.html"
extra_options = "e10s fission stylo webrender"
measurement_unit = "ms"

# Create base signature
base_sig = create_signature(
signature_hash=(20 * "k1"),
extra_options=extra_options,
platform=test_linux_platform,
measurement_unit=measurement_unit,
suite=suite,
test=test,
test_perf_signature=test_perf_signature,
repository=try_repository,
)

# Create base data point with replicates
base_job = perf_jobs[0]
base_job.push = test_perfcomp_push
base_job.save()
base_perf_datum = PerformanceDatum.objects.create(
value=103.0,
push_timestamp=base_job.push.time,
job=base_job,
push=base_job.push,
repository=try_repository,
signature=base_sig,
)
base_perf_datum.push.time = base_job.push.time
base_perf_datum.push.save()
# Add replicates for base
for replicate_value in [100.0, 105.0, 102.0, 104.0]:
PerformanceDatumReplicate.objects.create(
performance_datum=base_perf_datum, value=replicate_value
)

# Create new signature
new_sig = create_signature(
signature_hash=(20 * "k2"),
extra_options=extra_options,
platform=test_linux_platform,
measurement_unit=measurement_unit,
suite=suite,
test=test,
test_perf_signature=test_perf_signature,
repository=test_repository,
)

# Create new data point with replicates
new_job = perf_jobs[1]
new_job.push = test_perfcomp_push_2
new_job.save()
new_perf_datum = PerformanceDatum.objects.create(
value=113.0,
push_timestamp=new_job.push.time,
job=new_job,
push=new_job.push,
repository=test_repository,
signature=new_sig,
)
new_perf_datum.push.time = new_job.push.time
new_perf_datum.push.save()
# Add replicates for new
for replicate_value in [110.0, 115.0, 112.0, 114.0]:
PerformanceDatumReplicate.objects.create(
performance_datum=new_perf_datum, value=replicate_value
)

# Test without enable_silverman_kde (should not include KDE data)
query_params_without_kde = (
f"?base_repository={try_repository.name}&new_repository={test_repository.name}"
f"&new_revision={test_perfcomp_push_2.revision}"
f"&framework={test_perf_signature.framework_id}"
f"&interval=604800&no_subtests=true&test_version=mann-whitney-u"
)

response = client.get(reverse("perfcompare-results") + query_params_without_kde)
assert response.status_code == 200
results = response.json()
assert len(results) > 0, "Expected at least one result"
result_without_kde = results[0]
# Should have silverman_kde fields but set to None/empty
assert result_without_kde["silverman_kde"] is None
assert result_without_kde["silverman_warnings"] == []

# Test with enable_silverman_kde=true (should include KDE data)
query_params_with_kde = query_params_without_kde + "&enable_silverman_kde=true&replicates=true"

response = client.get(reverse("perfcompare-results") + query_params_with_kde)
assert response.status_code == 200
results_with_kde = response.json()
assert len(results_with_kde) > 0, "Expected at least one result with KDE enabled"
result_with_kde = results_with_kde[0]

# Verify silverman_kde data is present and has expected structure
assert result_with_kde["silverman_kde"] is not None
silverman_data = result_with_kde["silverman_kde"]

# Check for expected keys in silverman_kde response
assert "bandwidth" in silverman_data
assert silverman_data["bandwidth"] == "Silverman"
assert "base_mode_count" in silverman_data
assert "new_mode_count" in silverman_data
assert "modes" in silverman_data
assert isinstance(silverman_data["modes"], list)

# Verify warnings is a list (may be empty or contain warnings)
assert isinstance(result_with_kde["silverman_warnings"], list)


def test_mwu_cache_hit_returns_cached_response(
client,
create_signature,
Expand Down Expand Up @@ -1593,12 +1456,6 @@ def test_mwu_cache_different_params_produce_different_cache_keys(
cache_keys = set(PerfCompareMwuCache.objects.values_list("hash_key", flat=True))
assert len(cache_keys) == 2

# Then: the responses differ in silverman_kde content
first_result = first_response.json()[0]
second_result = second_response.json()[0]
assert first_result["silverman_kde"] is None
assert second_result["silverman_kde"] is not None


def test_mwu_cache_recalculates_after_data_change(
client,
Expand Down
20 changes: 0 additions & 20 deletions treeherder/webapp/api/performance_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,6 @@ class PerfCompareResultsSerializerV2(serializers.ModelSerializer):
is_confident = OptionalBooleanField()
graphs_link = serializers.CharField()
more_runs_are_needed = OptionalBooleanField(default=False)
is_fit_good = OptionalBooleanField(default=True)
is_improvement = serializers.BooleanField(required=False)
is_regression = serializers.BooleanField(required=False)
is_meaningful = serializers.BooleanField(required=False)
Expand All @@ -854,18 +853,6 @@ class PerfCompareResultsSerializerV2(serializers.ModelSerializer):
mann_whitney_test = StatisticsTestSerializer(many=False)
cliffs_delta = PerfCompareDecimalField(required=False)
cliffs_interpretation = serializers.CharField(default="")
warning_c_delta = serializers.CharField(required=False)
silverman_kde = SilvermanKDESerializer(many=False, default=None)

@gopar gopar Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both KDESerializer and SilvermanKDESerializer serializers are no longer being used. Should I remove them here or keep them in case?

silverman_warnings = serializers.ListField(
child=serializers.CharField(default=""),
default=[],
)
kde_base = KDESerializer(many=False, required=False)
kde_new = KDESerializer(many=False, required=False)
kde_warnings = serializers.ListField(
child=serializers.CharField(default=""),
default=[],
)
direction_of_change = serializers.CharField(default="")
cles = CLESSerializer(many=False, default=None)

Expand Down Expand Up @@ -900,7 +887,6 @@ class Meta:
"is_new_better",
"lower_is_better",
"is_confident",
"is_fit_good",
"more_runs_are_needed",
"direction_of_change",
"is_improvement",
Expand All @@ -921,13 +907,7 @@ class Meta:
"mann_whitney_test",
"cliffs_delta",
"cliffs_interpretation",
"warning_c_delta",
"cles",
"silverman_kde",
"silverman_warnings",
"kde_new",
"kde_base",
"kde_warnings",
]


Expand Down